"Charles P. Wright":
> Thanks for the patch, I've applied it to the source tree.

Thank you too.
Also I am afraid it is a bug too. (see attatched patch)

And as I mentioned before, I am using writable nfs branch. Will you
merge or refine some my patches if I send them to this ml? I am feeling
they can be better if I get some good advices.

- inode is not updated after link(2) (some utilities cannot work
  correctly).
  retrieve updated inode just after vfs_link, and make hidden_new_dentry
  and inode updated.
- symbolic links under /proc shows a branch path (some utilities cannot
  work correctly).
  hook symbolic link inode operations under /proc, in order to hide
  branch path in realpath.
- setting attributes such as chmod, chown etc. cannot work correctly.
  give a superuser privilege temporally to the process when setting
  attributes to inode, since user ids on both nfs client/server may be
  different.


Junjiro Okajima


--- unionfs-20050921-1517/dentry.cO     2005-09-22 04:17:02.000000000 +0900
+++ unionfs-20050921-1517/dentry.c      2005-09-22 21:57:14.555029224 +0900
@@ -138,7 +138,7 @@
                    unionfs_lookup_backend(dentry,
                                           positive ? INTERPOSE_REVAL :
                                           INTERPOSE_REVAL_NEG);
-               if (result && IS_ERR(result)) {
+               if (!result || IS_ERR(result)) {
                        err = 0;
                        goto out;
                }
_______________________________________________
unionfs mailing list
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs

Reply via email to