I was trying to find out why this might be a problem in the files as in
all my tests I could not reproduce the effects you reported, unless I
explicitly ignored ID3v1.1 tags - which I thought wasn't being done.
However, on looking at the Slim/Formats/MP3.pm shows a lot of
differences from the version I'm using in SlimServer 6.2.1 - primarily
:
Code:
--------------------
# Try to pull ID3v2 tags first. If those don't exist, proceed to v1
# Also try and get an APE tag, which may have ReplayGain data.
my $tags = MP3::Info::get_mp3tag($fh, 2, undef, 1);
if (!scalar keys %$tags) {
$tags = MP3::Info::get_mp3tag($fh, 1);
}
--------------------
which reads 'IDv2.2 tags, parsed for me, and APE tags too'.
Compare this to the earlier version :
Code:
--------------------
my $tags = MP3::Info::get_mp3tag($fh);
--------------------
which is 'Any tags, parsed for me, no APE tags'.
Since you want API+ID3v1, you need :
Code:
--------------------
my $tags = MP3::Info::get_mp3tag($fh, undef, undef, 1);
--------------------
Which is 'whatever tags are present, parse them for me, and give me APE
tags'. *IF* you have invalid ID3v2 tags present on files and you want to
forcibly ignore them, change that first 'undef' to '1'. Rather than
doing this, I tend to use the ID3v2 tool 'id3v2' to strip all ID3v2
tags before moving them to the collection.
In the absence of an ID3v2.4 footer editor, I'm stuck with ID3v1.1.
Anyhow, that's a more elegant solution as it retains your APE replay
gains and uses ID3v1 as you wanted. This is a useful place where a
configuration option for 'prefer ID3v1 over ID3v2' might be useful.
Better still, there could be a few little tick boxes somewhere for 'use
ID3v1', 'use ID3v2', and 'use APE'.
--
gerph
------------------------------------------------------------------------
gerph's Profile: http://forums.slimdevices.com/member.php?userid=1819
View this thread: http://forums.slimdevices.com/showthread.php?t=24437
_______________________________________________
unix mailing list
[email protected]
http://lists.slimdevices.com/lists/listinfo/unix