ralphy wrote: > When using a slider in jivelite I have to press the down key to increase > the slider and the up key to decrease it which is counter intuitive, at > least for me :p > > This functionality was introduce at commit > (6b880433e7a0bf73da66a19bc10d3c8c378269ee) > > Switching the moveSlider parameters fixes the slider direction keys. > > Code: -------------------- > > --- a/share/jive/jive/ui/Slider.lua > +++ b/share/jive/jive/ui/Slider.lua > @@ -367,9 +367,9 @@ function _eventHandler(self, event) > local keycode = event:getKeycode() > > if keycode == KEY_UP then > - self:_moveSlider(-1) > - elseif keycode == KEY_DOWN then > self:_moveSlider(1) > + elseif keycode == KEY_DOWN then > + self:_moveSlider(-1) > end > > if keycode == KEY_FWD then > -------------------- > >
Raphy - I've looked at this and think jivelite with a keyboard is doing what squeezeplay was "down" = increase slides, "up" = reduce slider. This is aligned to the overall approach to SB menus where the down button takes you further down the menu and the up button higher up it? [I installed the squeezeplay test applet on jivelite and it appeared to do the same thing as squeezeplay - are you testing any differently?] Can you give me a test case for the other core patch you have in your github so I understand it. ------------------------------------------------------------------------ Triode's Profile: http://forums.slimdevices.com/member.php?userid=17 View this thread: http://forums.slimdevices.com/showthread.php?t=98156 _______________________________________________ unix mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/unix
