Eric Dalquist wrote: > I just had the same comment from the CAS side. I think I'll replace > the 'JIRA Issue: AA-0000' with a rule that allows any commit through > that starts with 'AA-0000'. Just doing AA-0000 anywhere in the > message is very likely to find false positives which is why I would > require it at the start of the message.
Hi Eric, I agree. The issue number should be at the begining. How about requiring that the commit message must match: ^(NOJIRA|\[maven-release-plugin\]|[A-Z]+?-\d=?): I think you should be able to validate the issue number against jira in the commit hook script as well. George > > -Eric > > George Lindholm wrote: >> Eric Dalquist wrote: >> >>> Sounds like everyone is for it (the CAS folks are as well), I'll work >>> on getting this set up next week. >>> >>> Currently the script will allow commits with any of these strings in >>> the message to go through (none are case sensitive): >>> NOJIRA >>> JIRA Issue: AA-0000 >>> [maven-release-plugin] >>> >>> If people have suggestions for changes or other allowed strings let me >>> know. >>> >> >> >> Hi Eric, >> is that literally "JIRA Issue: AA-0000", or would the comment really >> start with "AA-0000"? >> My preferences would be for "AA-0000", again using Mylyn. >> >> George >> >>> -Eric >>> >>> George Lindholm wrote: >>> >>>> I'm all for. If you use Mylyn this will be done automatically for you >>>> when you do a commit. >>>> >>>> +1 >>>> >>>> George >>>> >>>> Eric Dalquist wrote: >>>> >>>> >>>>> Brad Szabo was kind enough to share a SVN script that would require a >>>>> Jira issue id to be referenced in the commit message for any commit. The >>>>> script can be bypassed explicitly by adding NOJIRA instead of an issue >>>>> ID and also allow commits from some automated tools such as the maven >>>>> release plugin. >>>>> >>>>> What are people's feelings on adding this script to our repository? It >>>>> would require developers to at least acknowledge if there isn't a >>>>> relevant Jira issue and remind us when we forget to add a reference to >>>>> the relevant issue that does exist. I don't want to add something that >>>>> is going to cause headaches or difficulties for commitiers but an >>>>> automated catch might be nice to help enforce good behavior. >>>>> >>>>> -Eric >>>>> >>>>> >>>>> >>>> >>>> >> >> >> -- [EMAIL PROTECTED] ITServices, UBC Senior Programmer Analyst phone: 604.822.4375 fax: 604.822.5116 -- You are currently subscribed to [email protected] as: [EMAIL PROTECTED] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
