One thing that I realize is not well documented but this commit reminded me of is the PortalApplicationContextLocator. I'd like as much as possible for PortalApplicationContextLocator.getApplicationContext() to not be used in new code. It was originally implemented for existing code that had no reasonable way to work via dependency injection or for command line tools that needed a common way to load up the portal app context (though not as well documented as such).
One thought for the Cernunnos Servlet/Portlet is to extend them and create SpringDistpacher specific versions so the servlet or portlet uses the Spring WebApplicationContextUtils directly to get the current ApplicationContext and provide it to the CRN script it executes as an attribute. None of this is a big issue or pressing in any way, just things to keep in mind as we move forward.
Thanks again for all the work Drew! -Eric Drew Wills wrote:
Eric,Just wrapped up the work on UP-2182: http://www.ja-sig.org/issues/browse/UP-2182If you want it configured differently or moved (i put it at the bottom of the Admin Tools tab), please help yourself or just drop me a note.drew
smime.p7s
Description: S/MIME Cryptographic Signature
