Re: [uportal-dev] Bug in RDBMDistributedLayoutStore.java in uPortal 3.2.2

[Eric Dalquist]

That is a very good catch and is a bug. Are you able to take care of getting that fixed? I think it affect trunk, 3.2, 3.1 and 3.0

-Eric

On 8/6/10 1:19 PM, Cris J Holdorph wrote:

Please take a look at uPortal 3.2.2 the file:



Specifically lines 1893-1903...

They look like this:


                    final ResultSet rs2 = pstmt2.executeQuery();
                    try {
                        while (rs2.next()) {
                            String pName = rs.getString(1);
                            if (tsd.containsParameterName(pName))

                        }
                    }
                    finally {
                        close(rs2);
                    }




---- Cris J H

uportal-impl/src/main/java/org/jasig/portal/layout/dlm/RDBMDistributedLayoutStore.java tsup.putParameterValue(pName, rs2.getString(2)); Shouldn't the 'rs.getString(1)' be 'rs2.getString(1)' instead? I'm changing this and checking it in as a fix to UP-2781. However, I would like feedback from whomever might have made the changes, to be sure I'm not missing something.

smime.p7s
Description: S/MIME Cryptographic Signature