-Eric
On 8/12/10 6:16 AM, Verhoeven, Ernst wrote:
hi, I suspect this might have been due to a partially unsuccessful patch with the file from https://issues.jasig.org/browse/UP-2630 https://issues.jasig.org/secure/attachment/11530/RDBMDistributedLayoutStore-3-1-1.patch I did check if it actually introduces the problem and as far as I can tell it doesn't. It does introduce the rs2 ResultSet though, so if the patching didn't go without hiccups it might have left the class in a shaky state. Let me know if you need a hand with any cleaning up :) -Ernst ________________________________________ From: [email protected] [[email protected]] on behalf of Cris J Holdorph [[email protected]] Sent: Monday, August 09, 2010 16:46 To: [email protected] Subject: Re: [uportal-dev] Bug in RDBMDistributedLayoutStore.java in uPortal 3.2.2 I fixed it in 3.2.x and trunk. It did not seem to be present in 3.1. I'll take a look at 3.0.x today, I don't remember if I checked that branch or not. ---- Cris J H On 08/06/2010 08:55 PM, Eric Dalquist wrote:That is a very good catch and is a bug. Are you able to take care of getting that fixed? I think it affect trunk, 3.2, 3.1 and 3.0 -Eric On 8/6/10 1:19 PM, Cris J Holdorph wrote:Please take a look at uPortal 3.2.2 the file: uportal-impl/src/main/java/org/jasig/portal/layout/dlm/RDBMDistributedLayoutStore.java Specifically lines 1893-1903... They look like this: final ResultSet rs2 = pstmt2.executeQuery(); try { while (rs2.next()) { String pName = rs.getString(1); if (tsd.containsParameterName(pName)) tsup.putParameterValue(pName, rs2.getString(2)); } } finally { close(rs2); } Shouldn't the 'rs.getString(1)' be 'rs2.getString(1)' instead? I'm changing this and checking it in as a fix to UP-2781. However, I would like feedback from whomever might have made the changes, to be sure I'm not missing something. ---- Cris J H-- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
smime.p7s
Description: S/MIME Cryptographic Signature
