Devs,

Looks to me like this changeset

https://github.com/Jasig/uPortal/pull/438

causes this unit test to fail:

http://goo.gl/KS6a6p

in this way:

https://gist.github.com/apetro/2ad26a798d6b33e87c49 .

Locally reverting the change:

https://github.com/apetro/uPortal/tree/try_reverting_UP-4264

locally fixes the problem.


Therefore I propose reverting this commit in master.


Shall I press the Revert button here, or should we handle this in another
way?  https://github.com/Jasig/uPortal/pull/438


Andrew


PS: Reminds me of the need to circle back and detangle this codebase and
build so that Travis-CI can reliably build and run the unit tests, to help
catch this kind of thing before Pull Request merge. :)

-- 
You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/uportal-dev

Reply via email to