JW> my uportal build script disables running the tests. A natural reaction to a build process that is way, way too expensive and punishing of running the unit tests.
Part of where I want to get with Semantic Versioning is being able to separate what’s currently a monolith in uportal-war/src/java into components small enough that it’s not too painful to run the unit tests on the one component I'm touching right at the moment, that are loosely coupled enough that I don’t have to whack all of the components all at once to get anything done, and that thus are in pieces small enough to build and test in the generous but not huge resource allocation that travis-ci affords. How do we get traction on doing that detangling, and calling the result uPortal 5? :) Kind regards, Andrew > On Oct 28, 2014, at 12:14 PM, James Wennmacher <[email protected]> wrote: > > Hi Andrew, > > Josh brought this to my attention late yesterday and I started looking into > it. I hope to have a fix pushed shortly. > > I apologize, I forgot my uportal build script disables running the tests. > > James Wennmacher - Unicon > 480.558.2420 > > On 10/28/2014 08:52 AM, Andrew Petro wrote: >> Devs, >> >> Looks to me like this changeset >> >> https://github.com/Jasig/uPortal/pull/438 >> >> causes this unit test to fail: >> >> http://goo.gl/KS6a6p >> >> in this way: >> >> https://gist.github.com/apetro/2ad26a798d6b33e87c49 . >> >> Locally reverting the change: >> >> https://github.com/apetro/uPortal/tree/try_reverting_UP-4264 >> >> locally fixes the problem. >> >> >> Therefore I propose reverting this commit in master. >> >> >> Shall I press the Revert button here, or should we handle this in another >> way? https://github.com/Jasig/uPortal/pull/438 >> >> >> Andrew >> >> >> PS: Reminds me of the need to circle back and detangle this codebase and >> build so that Travis-CI can reliably build and run the unit tests, to help >> catch this kind of thing before Pull Request merge. :) >> >> >> >> >> >> -- >> >> You are currently subscribed to [email protected] as: >> [email protected] >> To unsubscribe, change settings or access archives, see >> http://www.ja-sig.org/wiki/display/JSG/uportal-dev > > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
