I would like clarification of the Pull Request merge process.
Though https://wiki.jasig.org/display/UPC/Git+Workflow+for+Committers#GitWorkflowforCommitters-MergingPullRequests doesn't state it, I had the understanding that part of the responsibility of merging a pull request into uPortal (or the portlet projects) is that the merging person insures the Jira issue get marked as resolved and the fix versions are updated as appropriate.
I just noticed that hasn't been done with a number of PRs processed recently so I wanted to get clarification on whether I have an incorrect understanding of the process or not. If not, then I'll update the above link and we can use this as an opportunity to insure we are all on the same page (and inform new project commiters).
I do see a note at https://wiki.jasig.org/display/UPC/Git+Workflow+for+Committers#GitWorkflowforCommitters-Releasingartifacts about the release process validating the Jiras are resolved and I think that is good to have it there as a safety net, but it seems to me we don't want to dump it all on the Release Engineer. We should have the merging process resolve the Jira issue.
Please let me know if my understanding is incorrect. Thanks, -- James Wennmacher - Unicon 480.558.2420 -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
