James, It’s a good idea for the merging committer to bump the metadata on the related JIRA, yes.
I’ve been forgetting to do this on PRs I’ve been merging. I’d probably have remembered and taken a pass through closed PRs to update metadata sooner or later. :) It’s also a great idea for the release engineering process to audit the commits in the release, the PRs merged for the release, the JIRAs marked as fix-for the release, and the JIRAs marked as affecting the release. I agree keeping things clean helps to keep the release engineering workload down, but I also think that’s the only point in the process that works to catch and clean up all of this for a clean release with clean metadata. As a bigger story arc, I’d like to give up on JIRA and use GitHub’s issue tracker for uPortal. We’d give up much power, no doubt, but it’s mostly power we’re not using and lighter issue tracking more closely integrated with source control might be just fine, less complex, and one less item of infrastructure to worry about. Where issues are represented by a Pull Request, merging the pull request has the effect of resolving the issue in GitHub’s issue tracker. Where there’s a separate issue referenced in the right way by commit messages, adding the commit also has the effect of resolving the issue. GitHub’s issue tracker does Milestones — they’d probably be good enough for our modest issue tracking needs in uPortal. But hey, no rush, love the one you’re with, etc. Andrew > On Dec 1, 2014, at 3:12 PM, James Wennmacher <[email protected]> wrote: > > I would like clarification of the Pull Request merge process. > > Though > https://wiki.jasig.org/display/UPC/Git+Workflow+for+Committers#GitWorkflowforCommitters-MergingPullRequests > doesn't state it, I had the understanding that part of the responsibility of > merging a pull request into uPortal (or the portlet projects) is that the > merging person insures the Jira issue get marked as resolved and the fix > versions are updated as appropriate. > > I just noticed that hasn't been done with a number of PRs processed recently > so I wanted to get clarification on whether I have an incorrect understanding > of the process or not. If not, then I'll update the above link and we can > use this as an opportunity to insure we are all on the same page (and inform > new project commiters). > > I do see a note at > https://wiki.jasig.org/display/UPC/Git+Workflow+for+Committers#GitWorkflowforCommitters-Releasingartifacts > about the release process validating the Jiras are resolved and I think that > is good to have it there as a safety net, but it seems to me we don't want to > dump it all on the Release Engineer. We should have the merging process > resolve the Jira issue. > > Please let me know if my understanding is incorrect. > > Thanks, > > -- > James Wennmacher - Unicon > 480.558.2420 > > > -- > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
