ive never worked with fpgas before, so just general comments use spaces for indentation, not tabs. one indentation level should be 4 spaces. grep the diff for offenders.
make sure all files do not have trailing new lines
error strings need encapsulation by _(...)
all caps names are generally reserved for defines. so change PLD_FILE to
pld_file.
in the header, cmd file, and log-error files, please expand "PLD". in the top
intro areas, something in a comment like "Support for Programmable Logic
Devices (PLD)" should be sufficient.
the usage of global variables is disheartening, but currently there isnt much
you can do about this. we only have so many "private" fields, and generally
the major ones are already utilized. i'm thinking we need to introduce some
helper functions to attach an arbitrary amount of private state to a chain.
something like urj_private_state_{attach,get,detach}. maybe fodder for new
discussion.
the xlx_flip16() function looks like something that should be generalized and
moved into common code.
do not bother checking pointers for NULL before calling free(). it already
handles NULL pointers correctly.
- if (foo) free (foo);
+ free (foo);
otherwise, this looks pretty well written. hopefully someone familiar with
this stuff will review ;).
-mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________ UrJTAG-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/urjtag-development
