Hello,
I have been studying magnolia-module-google-analytics for my first
Magnolia module, which is also going to be a statistics module (but for
a different statistics provider). I noticed that the
GoogleAnalyticsVersionHandler overrides DefaultModuleVersionHandler's
getExtraInstallTasks() method and also adds the basic install tasks by
calling
installTasks.addAll(super.getBasicInstallTasks(ctx));
Does this make sense? It sounds a bit redundant to me. I'd expect the
install tasks returned by getExtraInstallTasks() to be performed as well
as the tasks returned by getBasicInstallTasks(), so why would
getExtraInstallTasks() also return the basic install tasks? Is this
actually necessary or just redundant/a bug?
Nils Breunese.
----------------------------------------------------------------
For list details see
http://www.magnolia-cms.com/home/community/mailing-lists.html
To unsubscribe, E-mail to: <[email protected]>
----------------------------------------------------------------
