Hey Nils, what you see is a bug in this module. Could you please create jira issue for it? The getExtraInstallTasks() is a method to override should you need to execute some custom tasks at module installation time and the basic installation tasks will be called prior to execution of the extra tasks. Ocassionaly there is a need to modify basic installation tasks and add extra task there, such as when installing custom data types and one need to register the type before data using this type are bootstrapped in the basic installation tasks. In such case you should however override the basic installation tasks and not the extra tasks. My guess would be that the author of the code was originally adding those extra tasks in the getBasicInstallTasks() method and only later changed the method name but forgot to remove the call to super. While it will not cause any side effects in this case the call is redundant.
Thanks. Jan > Hello, > > I have been studying magnolia-module-google-analytics for my first > Magnolia module, which is also going to be a statistics module (but for > a different statistics provider). I noticed that the > GoogleAnalyticsVersionHandler overrides DefaultModuleVersionHandler's > getExtraInstallTasks() method and also adds the basic install tasks by > calling > > installTasks.addAll(super.getBasicInstallTasks(ctx)); > > Does this make sense? It sounds a bit redundant to me. I'd expect the > install tasks returned by getExtraInstallTasks() to be performed as well > as the tasks returned by getBasicInstallTasks(), so why would > getExtraInstallTasks() also return the basic install tasks? Is this > actually necessary or just redundant/a bug? > > Nils Breunese. > > ---------------------------------------------------------------- > For list details see > http://www.magnolia-cms.com/home/community/mailing-lists.html > To unsubscribe, E-mail to: <[email protected]> > ---------------------------------------------------------------- ---------------------------------------------------------------- For list details see http://www.magnolia-cms.com/home/community/mailing-lists.html To unsubscribe, E-mail to: <[email protected]> ----------------------------------------------------------------
