On Thu, Mar 17, 2011 at 18:02, Eric Dumazet <eric.duma...@gmail.com> wrote:
> Le jeudi 17 mars 2011 à 12:55 -0400, Steven Rostedt a écrit :
>> Here, test this patch. I'm in the process of committing it now.
>> It will be two patches, one for the WARN_ON_SMP() change, the other for
>> the futex change.
>>
>> -- Steve
>>
>> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
>> index c2c9ba0..25f1e9e 100644
>> --- a/include/asm-generic/bug.h
>> +++ b/include/asm-generic/bug.h
>> @@ -168,7 +168,7 @@ extern void warn_slowpath_null(const char *file, const
>> int line);
>> #ifdef CONFIG_SMP
>> # define WARN_ON_SMP(x) WARN_ON(x)
>> #else
>> -# define WARN_ON_SMP(x) do { } while (0)
>> +# define WARN_ON_SMP(x) ({0;})
>> #endif
>>
>
> You meant :
>
> # define WARN_ON_SMP(x) ({x;})
>
> or
>
> # define WARN_ON_SMP(x) do { } while (x, 0)
>
> ?
I don't know. It's not clear to me if "WARN_ON_SMP(x)" should always return "x",
or only on SMP?
E.g.
if (WARN_ON_SMP(x)) {
// Should we get here if "x" is true?
// Or only if CONFIG_SMP and "x" are both true?
}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
