On Thu, 2011-03-17 at 14:22 -0400, Steven Rostedt wrote:
> On Thu, 2011-03-17 at 18:43 +0100, Geert Uytterhoeven wrote:
>
> > I don't know. It's not clear to me if "WARN_ON_SMP(x)" should always return
> > "x",
> > or only on SMP?
> >
> > E.g.
> >
> > if (WARN_ON_SMP(x)) {
> > // Should we get here if "x" is true?
> > // Or only if CONFIG_SMP and "x" are both true?
> > }
> >
>
> The "Or only if CONFIG_SMP and "x" are both true.
>
> I'll update the change to add a comment about that.
>
We are the first user of this false return, as do { } while (0) doesn't
return anything. I'll add a comment to explain the issue, but it makes
sense to have it returns false on UNIPROCESSOR.
-- Steve
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
