Am 20.10.2014 11:28 schrieb Daniel Walter <sa...@0x90.at>:
>
> ----- Original Message -----
> > From: "Thomas Meyer" <tho...@m3y3r.de>
> > To: "user-mode-linux-devel" <user-mode-linux-devel@lists.sourceforge.net>
> > Sent: Sunday, October 19, 2014 4:14:13 PM
> > Subject: [uml-devel] [PATCH v3 3/3] um: enable trace irqflags support
> >
> > Add TRACE_IRQFLAGS_SUPPORT to UML.
> > This enables LOCKDEP_SUPPORT and TRACING_SUPPORT.
>
>
> FYI: I'm currently working on porting ftrace() support to
> uml. It will take another week or two since I don't have enough
> time to debug, and it isn't stable yet (read as is panic()ing randomly)
Good to know :-)
Thanks for you stack trace support work!
BTW. When triggering a sysrq t with the uml console the stack trace is not
displayed, it says that the stack trace failed because a sigsegv happens in the
stack trace or something like that. Bug or feature?
>
> >
> > Signed-off-by: Thomas Meyer <tho...@m3y3r.de>
> > ---
> > diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
> > index 87bc868..6a33c3a 100644
> > --- a/arch/um/Kconfig.common
> > +++ b/arch/um/Kconfig.common
> > @@ -28,10 +28,9 @@ config PCI
> > config PCMCIA
> > bool
> >
> > -# Yet to do!
> > config TRACE_IRQFLAGS_SUPPORT
> > bool
> > - default n
> > + default y
> >
> > config LOCKDEP_SUPPORT
> > bool
> > diff --git a/arch/um/include/asm/irqflags.h
> > b/arch/um/include/asm/irqflags.h
> > index c780d8a..c5b636e 100644
> > --- a/arch/um/include/asm/irqflags.h
> > +++ b/arch/um/include/asm/irqflags.h
> > @@ -34,9 +34,9 @@ static inline unsigned long
> > arch_local_irq_save(void)
> > return flags;
> > }
> >
> > -static inline bool arch_irqs_disabled(void)
> > +static inline int arch_irqs_disabled_flags(unsigned long flags)
> > {
> > - return arch_local_save_flags() == 0;
> > + return flags == 0;
> > }
> >
> > #endif
>
> I'm not sure if this is correct. I'd rather would have another function
> implemented instead of removing the check for disabled irqs.
There is a default coding for arch_irqs_disabled which calls
arch_irqs_disabled_flags.
The logic after above change should be the same as before.
>
>
> cheers,
>
> daniel
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
