On Tue, Mar 3, 2015 at 5:55 AM, Lorenzo Colitti <lore...@google.com> wrote: > Hi, > > when compiling UML with -Wall -Werror, I get:
Don't build with -Werror. > arch/um/kernel/ptrace.c: In function ‘syscall_trace_enter’: > arch/um/kernel/ptrace.c:178:32: warning: ignoring return value of > ‘tracehook_report_syscall_entry’, declared with attribute > warn_unused_result [-Wunused-result] > error, forbidden warning: ptrace.c:178 > make[1]: *** [arch/um/kernel/ptrace.o] Error 1 > > This code hasn't changed in a long time (since 1bfa2317 in May 2012, I > think), so I assume this is intentional? > > Any thoughts on whether you'd like to fix this upstream, and if so > how? I can put a trivial fix into our trees (assign the result to a > dummy variable, or do "if (tracehook_report_syscall_entry()) return;") > but if you're thinking of fixing it upstream I should probably wait to > cherry-pick whatever fix you decide on. Just putting (void) in front > of the function does not silence the warning gcc. (This is apparently > working as intended - see > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509#c26 ) IIRC the big plan is to make tracehook_report_syscall_entry() tree-wide void. -- Thanks, //richard ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
