Hi, Yuval Thanks for your contribution. I am not a SQL expert, but it seems to be beneficial to users, and the amount of code is not much and only left is the test. Therefore, I am open to this entry into rc1. But according to the rules, you still have to see if there are other PMC's objections within 48 hours.
Best, Guowei On Thu, Apr 1, 2021 at 10:33 PM Yuval Itzchakov <yuva...@gmail.com> wrote: > Hi All, > > I would really love to merge https://github.com/apache/flink/pull/15307 > prior to 1.13 release cutoff, it just needs some more tests which I can > hopefully get to today / tomorrow morning. > > This is a critical fix as now predicate pushdown won't work for any stream > which generates a watermark and wants to push down predicates. > > On Thu, Apr 1, 2021, 10:56 Kurt Young <ykt...@gmail.com> wrote: > >> Thanks Dawid, I have merged FLINK-20320. >> >> Best, >> Kurt >> >> >> On Thu, Apr 1, 2021 at 2:49 PM Dawid Wysakowicz <dwysakow...@apache.org> >> wrote: >> >>> Hi all, >>> >>> @Kurt @Arvid I think it's fine to merge those two, as they are pretty >>> much finished. We can wait for those two before creating the RC0. >>> >>> @Leonard Personally I'd be ok with 3 more days for that single PR. I >>> find the request reasonable and I second that it's better to have a proper >>> review rather than rush unfinished feature and try to fix it later. >>> Moreover it got broader support. Unless somebody else objects, I think we >>> can merge this PR later and include it in RC1. >>> >>> Best, >>> >>> Dawid >>> On 01/04/2021 08:39, Arvid Heise wrote: >>> >>> Hi Dawid and Guowei, >>> >>> I'd like to merge [FLINK-13550][rest][ui] Vertex Flame Graph [1]. We are >>> pretty much just waiting for AZP to turn green, it's separate from other >>> components, and it's a super useful feature for Flink users. >>> >>> Best, >>> >>> Arvid >>> >>> [1] https://github.com/apache/flink/pull/15054 >>> >>> On Thu, Apr 1, 2021 at 6:21 AM Kurt Young <ykt...@gmail.com> wrote: >>> >>>> Hi Guowei and Dawid, >>>> >>>> I want to request the permission to merge this feature [1], it's a >>>> useful improvement to sql client and won't affect >>>> other components too much. We were plan to merge it yesterday but met >>>> some tricky multi-process issue which >>>> has a very high possibility hanging the tests. It took us a while to >>>> find out the root cause and fix it. >>>> >>>> Since it's not too far away from feature freeze and RC0 also not >>>> created yet, thus I would like to include this >>>> in 1.13. >>>> >>>> [1] https://issues.apache.org/jira/browse/FLINK-20320 >>>> >>>> Best, >>>> Kurt >>>> >>>> >>>> On Wed, Mar 31, 2021 at 5:55 PM Guowei Ma <guowei....@gmail.com> wrote: >>>> >>>>> Hi, community: >>>>> >>>>> Friendly reminder that today (3.31) is the last day of feature >>>>> development. Under normal circumstances, you will not be able to submit >>>>> new >>>>> features from tomorrow (4.1). Tomorrow we will create 1.13.0-rc0 for >>>>> testing, welcome to help test together. >>>>> After the test is relatively stable, we will cut the release-1.13 >>>>> branch. >>>>> >>>>> Best, >>>>> Dawid & Guowei >>>>> >>>>> >>>>> On Mon, Mar 29, 2021 at 5:17 PM Till Rohrmann <trohrm...@apache.org> >>>>> wrote: >>>>> >>>>>> +1 for the 31st of March for the feature freeze. >>>>>> >>>>>> Cheers, >>>>>> Till >>>>>> >>>>>> On Mon, Mar 29, 2021 at 10:12 AM Robert Metzger <rmetz...@apache.org> >>>>>> wrote: >>>>>> >>>>>> > +1 for March 31st for the feature freeze. >>>>>> > >>>>>> > >>>>>> > >>>>>> > On Fri, Mar 26, 2021 at 3:39 PM Dawid Wysakowicz < >>>>>> dwysakow...@apache.org> >>>>>> > wrote: >>>>>> > >>>>>> > > Thank you Thomas! I'll definitely check the issue you linked. >>>>>> > > >>>>>> > > Best, >>>>>> > > >>>>>> > > Dawid >>>>>> > > >>>>>> > > On 23/03/2021 20:35, Thomas Weise wrote: >>>>>> > > > Hi Dawid, >>>>>> > > > >>>>>> > > > Thanks for the heads up. >>>>>> > > > >>>>>> > > > Regarding the "Rebase and merge" button. I find that merge >>>>>> option >>>>>> > useful, >>>>>> > > > especially for small simple changes and for backports. The >>>>>> following >>>>>> > > should >>>>>> > > > help to safeguard from the issue encountered previously: >>>>>> > > > https://github.com/jazzband/pip-tools/issues/1085 >>>>>> > > > >>>>>> > > > Thanks, >>>>>> > > > Thomas >>>>>> > > > >>>>>> > > > >>>>>> > > > On Tue, Mar 23, 2021 at 4:58 AM Dawid Wysakowicz < >>>>>> > dwysakow...@apache.org >>>>>> > > > >>>>>> > > > wrote: >>>>>> > > > >>>>>> > > >> Hi devs, users! >>>>>> > > >> >>>>>> > > >> 1. *Feature freeze date* >>>>>> > > >> >>>>>> > > >> We are approaching the end of March which we agreed would be >>>>>> the time >>>>>> > > for >>>>>> > > >> a Feature Freeze. From the knowledge I've gather so far it >>>>>> still seems >>>>>> > > to >>>>>> > > >> be a viable plan. I think it is a good time to agree on a >>>>>> particular >>>>>> > > date, >>>>>> > > >> when it should happen. We suggest *(end of day CEST) March >>>>>> 31st* >>>>>> > > >> (Wednesday next week) as the feature freeze time. >>>>>> > > >> >>>>>> > > >> Similarly as last time, we want to create RC0 on the day after >>>>>> the >>>>>> > > feature >>>>>> > > >> freeze, to make sure the RC creation process is running >>>>>> smoothly, and >>>>>> > to >>>>>> > > >> have a common testing reference point. >>>>>> > > >> >>>>>> > > >> Having said that let us remind after Robert & Dian from the >>>>>> previous >>>>>> > > >> release what it a Feature Freeze means: >>>>>> > > >> >>>>>> > > >> *B) What does feature freeze mean?*After the feature freeze, >>>>>> no new >>>>>> > > >> features are allowed to be merged to master. Only bug fixes and >>>>>> > > >> documentation improvements. >>>>>> > > >> The release managers will revert new feature commits after the >>>>>> feature >>>>>> > > >> freeze. >>>>>> > > >> Rational: The goal of the feature freeze phase is to improve >>>>>> the >>>>>> > system >>>>>> > > >> stability by addressing known bugs. New features tend to >>>>>> introduce new >>>>>> > > >> instabilities, which would prolong the release process. >>>>>> > > >> If you need to merge a new feature after the freeze, please >>>>>> open a >>>>>> > > >> discussion on the dev@ list. If there are no objections by a >>>>>> PMC >>>>>> > member >>>>>> > > >> within 48 (workday)hours, the feature can be merged. >>>>>> > > >> >>>>>> > > >> 2. *Merge PRs from the command line* >>>>>> > > >> >>>>>> > > >> In the past releases it was quite frequent around the Feature >>>>>> Freeze >>>>>> > > date >>>>>> > > >> that we ended up with a broken main branch that either did not >>>>>> compile >>>>>> > > or >>>>>> > > >> there were failing tests. It was often due to concurrent >>>>>> merges to the >>>>>> > > main >>>>>> > > >> branch via the "Rebase and merge" button. To overcome the >>>>>> problem we >>>>>> > > would >>>>>> > > >> like to suggest only ever merging PRs from a command line. >>>>>> Thank you >>>>>> > > >> Stephan for the idea! The suggested workflow would look as >>>>>> follows: >>>>>> > > >> >>>>>> > > >> 1. Pull the change and rebase on the current main branch >>>>>> > > >> 2. Build the project (e.g. from IDE, which should be faster >>>>>> than >>>>>> > > >> building entire project from cmd) -> this should ensure the >>>>>> project >>>>>> > > compiles >>>>>> > > >> 3. Run the tests in the module that the change affects -> >>>>>> this >>>>>> > should >>>>>> > > >> greatly minimize the chances of failling tests >>>>>> > > >> 4. Push the change to the main branch >>>>>> > > >> >>>>>> > > >> Let us know what you think! >>>>>> > > >> >>>>>> > > >> Best, >>>>>> > > >> >>>>>> > > >> Guowei & Dawid >>>>>> > > >> >>>>>> > > >> >>>>>> > > >> >>>>>> > > >>>>>> > > >>>>>> > >>>>>> >>>>>
