Hello Adam,

thanks for taking time to look into this.

On Mon, Jul 19, 2010 at 8:32 AM, Adam Murdoch <[email protected]> wrote:

>  from 'a'
> from('b').include('**/*.java')
>
> this includes '**/*.java' from 'a' and 'b'
>
>
This is not very intuitive, IMHO.


> from 'a'
> from('b') { include '**/*.java' }
>
> this includes everything from 'a', and only '**/*.java' from 'b'
>
> Looking at the first example, I wonder if from() should always create and
> return a child copy spec, because the code certainly looks like you want
> everything from 'a' and only '**/*.java' from 'b'. But then, what should
> something like this do:
>
> from('a').from('b').include('**/*.java')
>

I'd expect it to include a/b/**/*.java. (I didn't realise from() calls could
be nested, though.)


>
> Not sure. I think I prefer having every form of from() create a child spec.
>
>
I agree.


>
>
>    1. When building an archive, should it be possible to use 
> from(someDir)without any configuration? This works for my source zip files, 
> but not for
>    my project's distribution (in the latter case, nothing gets added to the 
> zip
>    file until I add include '**').
>
>
> Include '**' should be the default, so the task should work without have to
> specify any includes. Do you have some more detail about how the archive
> task is configured?
>

The build file can be found here:
http://aluminumproject.googlecode.com/hg/build.gradle. When line 127 is
commented out, Gradle seems to freeze when running gradle createDistribution,
but it's creating a *huge* zip file (I never have had the patience to find
out whether it ends or not).

Reply via email to