Thanks for the suggestions. I'll update the code. Andy Oberstar
On Sun, May 15, 2011 at 3:51 PM, Adam Murdoch <[email protected]>wrote: > > On 15/05/2011, at 2:53 AM, Andrew Oberstar wrote: > > Hi all, > > I just released a few Gradle plugins for JDepend, PMD, and Findbugs. As > far as I could tell (I may be wrong), there aren't any pure plugins for > these tools. The code was mostly inspired by the samples in the Cookbook > and the code-quality plugin. The implementations aren't that great, but > they work for the most part. This is my first crack at this, so I welcome > any comments, suggestions, or criticism. > > > These look really good. You should list the plugins on the wiki: > http://wiki.gradle.org/display/GRADLE/Plugins > > Here are a few things you could do to simplify the code: > > - In JDepend, you can remove the onlyIf check added in the constructor, and > replace it with @SkipWhenEmpty on getClassesDir(). > > - You could make Findbugs.classpath and classes with @InputFiles instead of > @Input. Same for PMD.rulesets. You get some better validation and the > up-to-date checking is potentially faster when Gradle knows these are input > files. On the other hand, this is also something Gradle could figure out > from the types of the properties, so perhaps we should change Gradle in this > instance. > > > -- > Adam Murdoch > Gradle Co-founder > http://www.gradle.org > VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting > http://www.gradleware.com > >
