That patch isn't going to fix it, at leat not under Ubuntu, as I applied
it and still got the same compile error.

-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-
 Eskimo North Linux Friendly Internet Access, Shell Accounts, and Hosting.
   Knowledgeable human assistance, not telephone trees or script readers.
 See our web site: http://www.eskimo.com/ (206) 812-0051 or (800) 246-6874.

On Sun, 24 Feb 2019, Nick Couchman wrote:

Date: Sun, 24 Feb 2019 07:13:17 -0500
From: Nick Couchman <vn...@apache.org>
Reply-To: user@guacamole.apache.org
To: user@guacamole.apache.org
Subject: Re: Compile Error

On Sun, Feb 24, 2019 at 5:48 AM Robert Dinse <nan...@eskimo.com> wrote:


      Pulled the source from github and attempted to compile on Ubuntu
18.10 but
got the following error:

guac_svc/svc_service.c: In function ÿÿVirtualChannelEntryÿÿ:
guac_svc/svc_service.c:56:5: error: ÿÿstrncpyÿÿ output may be truncated
copying 7 bytes from a string of length 7 [-Werror=stringop-truncation]
      strncpy(svc_plugin->plugin.channel_def.name, svc->name,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              GUAC_RDP_SVC_MAX_LENGTH);
              ~~~~~~~~~~~~~~~~~~~~~~~~

      Any suggestions as to how to fix?  Normally an error like this would
not stop a compile but directives are given that cause all warnings to be
treated as errors so this stops the compile.


Looks like you're hitting this issue:

https://issues.apache.org/jira/browse/GUACAMOLE-637

which has an active pull request that is being review and will hopefully be
merged, soon.  Should be fixed in version 1.1.0.

https://github.com/apache/guacamole-server/pull/209

-Nick

Reply via email to