This is the patch I saw when I went to the URL provided:
â svc_service.c 2018-09-28 02:25:30.000000000 +0100
+++ svc_service.c 2018-10-01 11:32:34.839596780 +0100
@@ -55,6 +55,8 @@
/* Init channel def */
strncpy(svc_plugin->plugin.channel_def.name, svc->name,
GUAC_RDP_SVC_MAX_LENGTH);
+ svc_plugin->plugin.channel_def.name[GUAC_RDP_SVC_MAX_LENGTH] = '\0';
+
svc_plugin->plugin.channel_def.options =
CHANNEL_OPTION_INITIALIZED
CHANNEL_OPTION_ENCRYPT_RDP
As you can see it is quite different than the one you have.
-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-
Eskimo North Linux Friendly Internet Access, Shell Accounts, and Hosting.
Knowledgeable human assistance, not telephone trees or script readers.
See our web site: http://www.eskimo.com/ (206) 812-0051 or (800) 246-6874.
On Sun, 24 Feb 2019, Mike Jumper wrote:
Date: Sun, 24 Feb 2019 16:44:34 -0800
From: Mike Jumper <mjum...@apache.org>
Reply-To: user@guacamole.apache.org
To: user@guacamole.apache.org
Subject: Re: Compile Error
The patch was not after the line; it entirely replaced it. Relevant portion
of patch:
@@ -53,7 +54,7 @@ int VirtualChannelEntry(PCHANNEL_ENTRY_POINTS
pEntryPoints) {
guac_rdp_svc* svc = (guac_rdp_svc*) entry_points_ex->pExtendedData;
/* Init channel def */
- strncpy(svc_plugin->plugin.channel_def.name, svc->name,
+ guac_strlcpy(svc_plugin->plugin.channel_def.name, svc->name,
GUAC_RDP_SVC_MAX_LENGTH);
svc_plugin->plugin.channel_def.options =
CHANNEL_OPTION_INITIALIZED
If you're still seeing an error regarding strncpy() on that line, then the
patch has not been applied. There are no remaining calls to strncpy()
within the patched svc_service.c.
- Mike
On Sun, Feb 24, 2019 at 4:33 PM Robert Dinse <nan...@eskimo.com> wrote:
I got the same error, possible or not. The patch was AFTER the line
that errored so don't see how it would have fixed the error anyway.
-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-
Eskimo North Linux Friendly Internet Access, Shell Accounts, and Hosting.
Knowledgeable human assistance, not telephone trees or script readers.
See our web site: http://www.eskimo.com/ (206) 812-0051 or (800)
246-6874.
On Sun, 24 Feb 2019, Mike Jumper wrote:
Date: Sun, 24 Feb 2019 15:56:30 -0800
From: Mike Jumper <mjum...@apache.org>
Reply-To: user@guacamole.apache.org
To: user@guacamole.apache.org
Subject: Re: Compile Error
It's not possible for the same error to be present with the patched code.
The line in question no longer exists with the patch, having been
replaced
with a call to guac_strlcpy(). If you're still seeing an error on that
line
regarding strncpy(), you're not building the patch that Nick mentioned.
- Mike
On Sun, Feb 24, 2019 at 3:46 PM Robert Dinse <nan...@eskimo.com> wrote:
That patch isn't going to fix it, at leat not under Ubuntu, as I
applied
it and still got the same compile error.
-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-
Eskimo North Linux Friendly Internet Access, Shell Accounts, and
Hosting.
Knowledgeable human assistance, not telephone trees or script
readers.
See our web site: http://www.eskimo.com/ (206) 812-0051 or (800)
246-6874.
On Sun, 24 Feb 2019, Nick Couchman wrote:
Date: Sun, 24 Feb 2019 07:13:17 -0500
From: Nick Couchman <vn...@apache.org>
Reply-To: user@guacamole.apache.org
To: user@guacamole.apache.org
Subject: Re: Compile Error
On Sun, Feb 24, 2019 at 5:48 AM Robert Dinse <nan...@eskimo.com>
wrote:
Pulled the source from github and attempted to compile on Ubuntu
18.10 but
got the following error:
guac_svc/svc_service.c: In function ÿÿÿÿVirtualChannelEntryÿÿÿÿ:
guac_svc/svc_service.c:56:5: error: ÿÿÿÿstrncpyÿÿÿÿ output may be
truncated
copying 7 bytes from a string of length 7
[-Werror=stringop-truncation]
strncpy(svc_plugin->plugin.channel_def.name, svc->name,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GUAC_RDP_SVC_MAX_LENGTH);
~~~~~~~~~~~~~~~~~~~~~~~~
Any suggestions as to how to fix? Normally an error like this
would
not stop a compile but directives are given that cause all warnings to
be
treated as errors so this stops the compile.
Looks like you're hitting this issue:
https://issues.apache.org/jira/browse/GUACAMOLE-637
which has an active pull request that is being review and will
hopefully
be
merged, soon. Should be fixed in version 1.1.0.
https://github.com/apache/guacamole-server/pull/209
-Nick
