Hi There, When connect to Cisco-IOS-XRv-9000 by ssh guacd failed with "Unable to allocate PTY" error. As it is critical for us, I played around and found that guacd failed on PTY request "libssh2_channel_request_pty()". After some debugging on guacd and libssh2 I found that request is sent successfully, but it failed on receiving specific packet type. I created the below patch for guacd, added warning instead of "guac_client_abort()" and it worked.
Currently we are using custom builds, but it would be great to add the fix to the code base to avoid such cases. Can you help me with the solution? Thanks. >From d5c0e7aa4c38db04d0bf7adb817ca9f392c7f619 Mon Sep 17 00:00:00 2001 From: Yaroslav <[email protected]> Date: Fri, 2 Apr 2021 07:05:20 +0000 Subject: [PATCH] Continue execution if PTY request failed --- src/protocols/ssh/ssh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/protocols/ssh/ssh.c b/src/protocols/ssh/ssh.c index 81fb0855..e7f9eeb0 100644 --- a/src/protocols/ssh/ssh.c +++ b/src/protocols/ssh/ssh.c @@ -368,8 +368,7 @@ void* ssh_client_thread(void* data) { settings->terminal_type, strlen(settings->terminal_type), ssh_ttymodes, ttymodeBytes, ssh_client->term->term_width, ssh_client->term->term_height, 0, 0)) { - guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR, "Unable to allocate PTY."); - return NULL; + guac_client_log(client, GUAC_LOG_WARNING, "Unable to allocate PTY."); } /* Forward specified locale */ -- 2.20.1 -- Sent from: http://apache-guacamole-general-user-mailing-list.2363388.n4.nabble.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
