Hi Bengt,

I'm agree to add at least a workaround on the 2.2.x branch in order to handle system properties.

Let us work on that after the 2.2.2 release.

Regards
JB

On 06/28/2011 11:46 AM, Bengt Rodehav wrote:
OK JB,

It would be nice then if Karaf 3.0 would be easily extendable and
customisable without having to change the standard Karaf distribution
itself. Hope you keep that wish in mind...

Would it be possible to at least consider a way to add system properties
outside of the Karaf installation for Karaf 2.2.3 (3.0 feels too far
away for me...)?

Right now it seems like the handling of the system.properties file is
hard coded (not configured in config.properties). Ideally a list of
files containing system properties would be configured in
config.properties. I could then use custom.properties to add my own file
containing system.properties.

Also, the idea with having a "custom.properties" is that it will only
contain customised properties and nothing that is used by the Karaf
standard distribution. It should therefore be empty or non-existent in
the Karaf distribution. When updating to use a new version of Karaf I
should not have to "merge" my custom.properties with the one distributed
with Karaf.

Yes, I can always modify the system.properties to add my own system
properties (which I have to do today). However, every time a new Karaf
version is released I have to merge my modified file with the Karaf
version. I could perhaps live with that if it only affected my standard
installation package. Unfortunately, customised system properties is
needed on an installation basis. Meaning that it's done by more people
than myself. Also, it is very unsuitable to mix required system
properties from Karaf with custom/optional properties for a specific
installation. Things can get messed up easily.

What ideas do yo have in mind for Karaf 3.0?

/Bengt

2011/6/28 Jean-Baptiste Onofré <[email protected] <mailto:[email protected]>>

    Hi Bengt,

    I moved some issues on Karaf 2.2.3 as we need Karaf 2.2.2 very soon.
    Your issues will be fixed on 2.2.3 and 3.0.0.

    On the other hand, we discussed about Karaf distributions and
    profiles for Karaf 3.0.0.

    Regards
    JB


    On 06/28/2011 10:51 AM, Bengt Rodehav wrote:

        JB,

        I noticed that Karaf 2.2.2 is in the works. Have you had any time to
        look at the issues I reported? At least concerning adding system
        properties outside the Karaf installation?

        /Bengt

        2011/6/9 Bengt Rodehav <[email protected]
        <mailto:[email protected]> <mailto:[email protected]
        <mailto:[email protected]>>>

            Thanks JB!

            /Bengt

            2011/6/9 Jean-Baptiste Onofré <[email protected]
        <mailto:[email protected]> <mailto:[email protected]
        <mailto:[email protected]>>>

                Hi Bengt,

                thanks for the reminder and sorry that you don't get any
                feedback before.

                I'm gonna take a look on your issues.

                Regards
                JB


                On 06/09/2011 07:38 PM, Bengt Rodehav wrote:

                    Hi JB,

                    I've created a product (called Connect) that customises
                    Karaf in lots of
                    different ways. One of them is to modify karaf.bat and
                    karaf-wrapper.conf in order to set a number of
        "standard" system
                    properties that Connect depends on.

                    However, Connect is a pretty general integration
        platform
                    that we use in
                    many different ways - it is not feasible to make
        customised
                    packaging in
                    all these cases. Users need to be able to define
        their own
                    (installation
                    specific) system properties to be used in e g
        configuration
                    files picked
                    up by file install. I want these system properties to be
                    defined outside
                    of the Karaf installation without having to modify the
                    installation itself.

                    I've written about customisation of Karaf before on this
                    list (I think
                    you took part in that conversation).

                    I ended up creating the following JIRA's but I
        haven't seen
                    any activity
                    in this area which is why I now try to narrow down
        the scope
                    to just
                    adding system properties using an extension point.

        https://issues.apache.org/__jira/browse/KARAF-474
        <https://issues.apache.org/jira/browse/KARAF-474>
        https://issues.apache.org/__jira/browse/KARAF-475
        <https://issues.apache.org/jira/browse/KARAF-475>

                    For me, it's very important that it is possible to
        customise
                    Karaf by
                    extension points - not by modifying the files that are
                    included in the
                    Karaf installation.

                    /Bengt



                    2011/6/9 Jean-Baptiste Onofré <[email protected]
        <mailto:[email protected]>
        <mailto:[email protected] <mailto:[email protected]>>
        <mailto:[email protected] <mailto:[email protected]>

        <mailto:[email protected] <mailto:[email protected]>>>>


                        Hi Bengt,

                        What you can do is:

                        bin/karaf /tmp/my-rc

                        and my-rc can contain:

                        JAVA_OPTS="-Dmy.property=my"

                        You will have my.property in the System
        properties and
                    you will be
                        able to use it in blueprint for instance.

                        Regards
                        JB


                        On 06/09/2011 04:18 PM, Bengt Rodehav wrote:

                            I would like to add system properties to Karaf
                    without having to
                            manually edit the file system.properties.
        The reason
                    is that I
                            want to
                            be able to use as much as possible of a vanilla
                    Karaf. Is that
                            possible?

                            I have seen that custom.properties can be
        used to
                    override
                            settings in
                            config.properties but I haven't seen any
        property
                    that allows me to
                            specify a filename containing system properties.
                    What I'm
                            looking for is
                            something similar to the "${includes}"
        property in
                            config.properties.
                            That property allows me to list several
        files that
                    contain
                            configuration
                            properties. It would be nice if
        config.properties
                    contained a
                            property -
                            say "system.properties" that would contain a
        list of
                    files
                            containing
                            system properties that would be added at
        boot time.

                            /Bengt





Reply via email to