Hey JB, OK; I think we've two different situations here
a) we need at least some background logs; e.g. if you register a feature via the featureService directly or via the etc/org.apache.karaf.features.cfg b) in addition it would be nice to have a -v param for the command to get some output during the installation directly on the console. Independently that one is required to be implemented for every command separately; therefore I'm not really sure if it would make sense to add this into the core? In addition I'm not sure if the -v param is (compared to the log) really required for each command. E.g. what should -v output for log:tail? Kind regards, Andreas On Wed, Aug 8, 2012 at 5:20 PM, Jean-Baptiste Onofré <[email protected]> wrote: > Hey Andreas, > > I don't want to move anything in OsgiCommandSupport. If we consider that > "verbose" option should be present in most/all commands, we can add the > option directly into OsgiCommandSupport. > > My 0.02$ > > Regards > JB > > > On 08/08/2012 04:55 PM, Andreas Pieber wrote: >> >> OK, sorry but I really don't get what you mean :-) Can you please >> detail your idea a bit? What exactly do you want to move to the >> OsgiCommandSupport? >> >> Kind regards, >> Andreas >> >> On Tue, Aug 7, 2012 at 5:49 PM, Jean-Baptiste Onofré <[email protected]> >> wrote: >>> >>> It sounds good, in that case we can add this directly in >>> OsgiCommandSupport >>> as most of the commands (all ?) extends it. >>> >>> Regards >>> JB >>> >>> >>> On 08/07/2012 05:41 PM, Andreas Pieber wrote: >>>> >>>> >>>> IMHO the verbose feature is interesting for everything on the >>>> commandline; the log should always be written, at least at some >>>> extend, independent from the -v param; shouldn't it? >>>> >>>> Kind regards, >>>> Andreas >>>> >>>> On Tue, Aug 7, 2012 at 5:35 PM, Jean-Baptiste Onofré <[email protected]> >>>> wrote: >>>>> >>>>> >>>>> We already did this for the instance (add a verbose flag to write in >>>>> the >>>>> log >>>>> file), so it makes sense to do the same for features. >>>>> >>>>> Regards >>>>> JB >>>>> >>>>> >>>>> On 08/07/2012 05:15 PM, Andreas Pieber wrote: >>>>>> >>>>>> >>>>>> >>>>>> but those are written to the console; maybe we should have some basic >>>>>> log to the log during the process too in info mode? >>>>>> >>>>>> Kind regards, >>>>>> Andreas >>>>>> >>>>>> On Tue, Aug 7, 2012 at 4:19 PM, Jean-Baptiste Onofré <[email protected]> >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> Hi guys, >>>>>>> >>>>>>> FYI, in pure Karaf commands, we have the -v (verbose) option to see >>>>>>> where >>>>>>> we >>>>>>> are in the features installation process (to know which bundle is in >>>>>>> download, etc). >>>>>>> >>>>>>> Regards >>>>>>> JB >>>>>>> >>>>>>> >>>>>>> On 08/07/2012 03:34 PM, Andreas Pieber wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Hey Martin, >>>>>>>> >>>>>>>> Sounds like a great idea; can you create an jira for this that we >>>>>>>> don't loose track of this improvement? (an attached patch is btw, >>>>>>>> always welcomed too ;-)) >>>>>>>> >>>>>>>> Kind regards, >>>>>>>> Andreas >>>>>>>> >>>>>>>> On Tue, Aug 7, 2012 at 3:30 PM, lichtin <[email protected]> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Hi >>>>>>>>> During testing with Pax-Exam, I noticed there's no (info) log >>>>>>>>> output >>>>>>>>> at >>>>>>>>> all >>>>>>>>> during a feature installation. >>>>>>>>> Installing some larger feature can take a long time and it would be >>>>>>>>> nice >>>>>>>>> to >>>>>>>>> see some progress. >>>>>>>>> >>>>>>>>> My suggestion is to change the log level to INFO for the >>>>>>>>> "Installing >>>>>>>>> bundle" >>>>>>>>> lines: >>>>>>>>> >>>>>>>>> 2012-08-07 14:57:21,760 | DEBUG | Thread-7 | >>>>>>>>> FeaturesServiceImpl >>>>>>>>> | 39 - org.apache.karaf.features.core - 2.2.8 | Installing bundle >>>>>>>>> mvn:org.apache.cxf/cxf-rt-ws-addr/2.6.1 >>>>>>>>> 2012-08-07 14:57:21,846 | DEBUG | Thread-7 | >>>>>>>>> FeaturesServiceImpl >>>>>>>>> | 39 - org.apache.karaf.features.core - 2.2.8 | Installing bundle >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.ehcache/2.5.1_1 >>>>>>>>> >>>>>>>>> and perhaps also for the "Installing feature" lines: >>>>>>>>> >>>>>>>>> 2012-08-07 14:57:47,359 | DEBUG | Thread-7 | >>>>>>>>> FeaturesServiceImpl >>>>>>>>> | 39 - org.apache.karaf.features.core - 2.2.8 | Installing feature >>>>>>>>> camel-core 2.10.0 >>>>>>>>> 2012-08-07 14:57:47,359 | DEBUG | Thread-7 | >>>>>>>>> FeaturesServiceImpl >>>>>>>>> | 39 - org.apache.karaf.features.core - 2.2.8 | Installing feature >>>>>>>>> spring >>>>>>>>> 3.0.7.RELEASE >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> View this message in context: >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> http://karaf.922171.n3.nabble.com/No-info-log-output-when-installing-a-feature-tp4025433.html >>>>>>>>> Sent from the Karaf - User mailing list archive at Nabble.com. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Jean-Baptiste Onofré >>>>>>> [email protected] >>>>>>> http://blog.nanthrax.net >>>>>>> Talend - http://www.talend.com >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Jean-Baptiste Onofré >>>>> [email protected] >>>>> http://blog.nanthrax.net >>>>> Talend - http://www.talend.com >>> >>> >>> >>> -- >>> Jean-Baptiste Onofré >>> [email protected] >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com > > > -- > Jean-Baptiste Onofré > [email protected] > http://blog.nanthrax.net > Talend - http://www.talend.com
