It supports namespacing-ish -- it doesn't support resolving messages across namespaces, but when it renders the hrl and erl files, they are properly namespaced.
On Wed, Jun 15, 2016 at 12:38 PM, Benjamin Mahler <[email protected]> wrote: > Is this the right project? > https://github.com/tomas-abrahamsson/gpb > > If so, it seems to support package namespacing, just needs to be enabled: > > "Gpb can optionally make use of the package attribute by prepending the name > of the package to every contained message type (if defined), which is useful > to avoid name clashes of message types across packages." > > On Wed, Jun 15, 2016 at 1:37 AM, Sargun Dhillon <[email protected]> wrote: >> >> It turns out that not all protobufs compilers support dealing with >> packages correctly. The specific one I'm hitting an issue with today >> is gpb, the Erlang protobuf compiler. It's also a little bit weird in >> Python, and some of the other protobuf compilers. After doing a little >> bit of poking around, it appears we're doing this in only one place: >> >> Message: >> >> https://github.com/apache/mesos/blob/master/include/mesos/v1/mesos.proto#L1123-L1132 >> >> Reference: >> >> https://github.com/apache/mesos/blob/master/include/mesos/v1/scheduler/scheduler.proto#L344-L346 >> >> Given the reference is literally just wrapping the other one directly, >> I'm not even sure of what the immediate point of his is. Instead, >> could we move to a flat namespace, so that for us who don't have >> compilers that can handle protobuf packages, we can just treat all of >> the pb files as one giant flat file? >> >> I don't think this would take much change for the existing code, but >> it's more about the future. > >
