Do we really want to commit this patch, and have OFBiz display all currency
values with 10 decimal figures?
My opinion is: definitely no.
If we want to display more decimal digits in certain places we should add an
optional attribute/parameter to the transform and then specify it explicitly in
certain spots, like 3 or 4 or based on db data number of digits.
-David
Scott Gray wrote:
I've committed the changes in rev. 535415
As I mentioned above, someone with framework commit privileges needs to
look at the rounding of displayed currency. I've attached a patch with
the changes I think are needed. If it doesn't see any action in the
short term I'll throw it in the jira.
Regards
Scott
On 05/05/07, *Scott Gray* <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
wrote:
I had planned on working the patch in this weekend, I just need to
clean it up a bit.
One thing I need a framework guy to look at is the rounding currency
formatting in widgets and the freemarker transform, I think we need
to set the default to something like 10 decimal places instead of
the currency's default. That way any rounding problems aren't
hidden by the display code and it also allows us to display tax
items to 3 decimal places (or whatever the arithmetic.properties has
set).
Also, salestax.calc.decimals is a bit of misnomer considering the
best we can do when storing intermediate tax is currency-precise at
3 decimal places.
And yes I did get paid (tax free, for the moment at least) :-)
Regards
Scott
On 05/05/07, *Jacopo Cappellato* < [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>> wrote:
Yes,
and, Scott, did you get your 500$ ? :-)
Jacopo
David E Jones wrote:
>
> Scott,
>
> Did this ever make it into OFBiz? I only reviewed it briefly,
but if it
> is fixing this problem then it would be great to have it in
the ofbiz
> trunk.
>
> -David
>
