Jonathon Haven't heard your dulcet tones in quite a while. Welcome back.
Skip -----Original Message----- From: Jonathon -- Improov [mailto:[EMAIL PROTECTED] Sent: Wednesday, April 16, 2008 6:14 AM To: [email protected] Subject: Re: OrderReadHelper doubling some of the item subtotal calculations???? Hi Anne, Yes, you're right. In fact, for just about EVERY project I did involving rentals or similar, I've had to completely overhaul that Java file. I've found myself coding very unique order calcs and handling for every unique business. Not sure how any of those can be rolled into OFBiz for generic use. Be prepared to roll your own, re-writing much of the codes there. Another problem is EFT payments, truly odd. I think you'll find some taxes and payment stuff requiring some degree of rewrite, seeing how you're in Australia. :) There are also some serious bugs in order item explosion codes. Beware. The problems permeate many areas to do with order items, including and especially tax calculations. Jon Bilgin Ibryam wrote: > Hi Anne, > > the code in these methods is very confusing and a refactoring is needed > for sure. > But at the moment it calculates the item subtotals right. > > If the workEfforts is not null, WorkOrderItemFulfillments is null and " > itemTotal = > itemTotal.multiply(getWorkEffortRentalQuantity(workEffort)).setScale(scale, > rounding); " is not called at all. That's why it doesn't calculates it > twice... > > And if the workEffort is null , then "itemTotal = > itemTotal.multiply(getWorkEffortRentalQuantity(workEffort)).setScale(scale, > rounding); " is called. > > Bilgin > > No virus found in this incoming message. Checked by AVG. Version: 7.5.519 / Virus Database: 269.22.13/1377 - Release Date: 4/14/2008 9:26 AM No virus found in this outgoing message. Checked by AVG. Version: 7.5.519 / Virus Database: 269.22.13/1377 - Release Date: 4/14/2008 9:26 AM
