-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Thank you Bilgin. I didn't understand that WorkOrderItemFulfillments would be null if workEfforts was not null. It makes all the difference to my reading of that code.
I'm not actually trying to use the rental options at this stage, just trying to learn my way around well enough to make some modifications. I'd prefer to change things the "right" way, if I can work out what the right way is! Cheers, Anne. Bilgin Ibryam wrote: > Hi Anne, > > the code in these methods is very confusing and a refactoring is needed > for sure. > But at the moment it calculates the item subtotals right. > > If the workEfforts is not null, WorkOrderItemFulfillments is null and " > itemTotal = > itemTotal.multiply(getWorkEffortRentalQuantity(workEffort)).setScale(scale, > rounding); " is not called at all. That's why it doesn't calculates it > twice... > > And if the workEffort is null , then "itemTotal = > itemTotal.multiply(getWorkEffortRentalQuantity(workEffort)).setScale(scale, > rounding); " is called. > > Bilgin > - -- Coherent Software Australia Pty Ltd PO Box 2773 Cheltenham Vic 3192 Phone: (03) 9585 6788 Fax: (03) 9585 1086 Web: http://www.cohsoft.com.au/ Email: [EMAIL PROTECTED] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIBtcytgv4pchABrERAp0eAJoCHTvkvBSapzBtK1pze5TRcCjt1ACfVyl0 2ftx7ev9icC6+rmmg6DGFYc= =enbO -----END PGP SIGNATURE-----
