Hi Abdullah,
I had a quick look and it seems good. I will commit I guess.
Thanks (and thank you to Sumit for the link and 1st review)
Jacques
From: "Abdullah Shaikh" <[email protected]>
I feel that we should have this service,
1) To get party's data, either we should have all the code in a class or all
should be exposed as a service, to avoid confusion. Right now, it's
partially from the service (i.e. email & telephone) and partially from the
ContactMechWorker class. All should be exposed as a service.
2) Also, as in the case of email & telephone, we can export the service, no
service for postal address to export.
Does this makes sense ?, if yes, then I thought of making a service wrapper
for ContactMechWorker.getCurrentPostalAddress &
ContactMechWorker.getPartyPostalAddresses, but then I noticed that one of
the parameter for these methods is ServletRequest object. In this case what
can be done is create a service and can it from the methods above, instead
of they hitting the delegator.
Please let me know your thoughts ? or am I missing something else ?
On Fri, Sep 18, 2009 at 2:54 AM, Jacques Le Roux <
[email protected]> wrote:
There are ContactMechWorker.getCurrentPostalAddress
ContactMechWorker.getPartyPostalAddresses
But yes no services, maybe because it's not needed ?
Jacques
From: "Abdullah Shaikh" <[email protected]>
There are services to get the party telephone & email, getPartyTelephone &
getPartyEmail respectively, but no service to get the party postal
address.
I can submit a patch for getPartyPostalAddress service, to get the party's
postal address. What do you think ?
