Re: No service to get party postal address

[Scott Gray]

Hmm those methods do look a little bit out of the ordinary, perhaps it might be better to just implement the service from scratch. Just be sure to follow the same patterns as used by the other ContactMech services.

Regards
Scott

On 19/09/2009, at 12:57 AM, Abdullah Shaikh wrote:

Yes, initially I thought of that, i.e. to wrap the worker method by service,

but both the methods expects ServletRequest object as the parameter.

Regarding moving the code to the service, there is another issue, the
getPartyPostalAddresses returns contactMech, partyContactMech &

file where this method is called, same is the issue with
getCurrentPostalAddres.

I guess we can commit the patch for getPartyPostalAddress, as it just
returns the postaladdress of the specified party and the specified
contactMechPurposeTypeId which is optional. Any other thoughts ?

partyContactMechPurposes objects in the result and retrieved by the groovy On Fri, Sep 18, 2009 at 6:00 PM, Scott Gray <scott.g...@hotwaxmedia.com >wrote:

I wouldn't attempt to call the service from the worker method, doing so

would require that the be signature changed which means you have to

service and deprecate the worker.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com




On 18/09/2009, at 9:23 PM, Abdullah Shaikh wrote:

cool I will do that .... it's more clear now

deprecate the existing method and create a new one (which is a bit pointless because callers might as well call the service themselves). I would either use the service to wrap the worker method or otherwise move the code to

On Fri, Sep 18, 2009 at 2:41 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

From: "Abdullah Shaikh" <abdullah.sha...@viithiisys.com>

I got confused. You meant that you will commit the already provided

patch
?.

It was really a cursory review and I must I did not thought about
generalising.

I was having ContactMechWorker.getCurrentPostalAddress &

ContactMechWorker.getPartyPostalAddresses, in my mind, what I was
thinking

the

it
is

provided
?

Let me know.

was that to make the getPartyPostalAddress service in java by taking the code out of the ContactMechWorker methods, and calling this service from ContactMechWorker class, or should we let ContactMechWorker methods as ? and the getPartyPostalAddress service in simple-method as already

Yes you are right, but be sure to mimic exactly current behaviours.

Thanks

Jacques



On Fri, Sep 18, 2009 at 1:06 PM, Abdullah Shaikh <

abdullah.sha...@viithiisys.com> wrote:

Hi Jacques,

I will provide the patch as discussed.

Just to be sure, what I need to do is :


&
ContactMechWorker.getPartyPostalAddresses

The patch that I already submitted, won't suffice, for the

work

methods.

Thanks,
Abdullah


On Fri, Sep 18, 2009 at 12:49 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Hi Abdullah,

1) Create a service to get party postaladdress (getPartyPostalAddress) 2) Call this service from the ContactMechWorker.getCurrentPostalAddress ContactMechWorker methods, I guess. I will need to change it to make it as per ContactMechWorker methods, so as to get it called from these

I had a quick look and it seems good. I will commit I guess.

Thanks (and thank you to Sumit for the link and 1st review)


Jacques

From: "Abdullah Shaikh" <abdullah.sha...@viithiisys.com>

I feel that we should have this service,

or
all

from
the
ContactMechWorker class. All should be exposed as a service.

2) Also, as in the case of email & telephone, we can export the
service,
no
service for postal address to export.


wrapper
for ContactMechWorker.getCurrentPostalAddress &

one
of

case
what

instead
of they hitting the delegator.




On Fri, Sep 18, 2009 at 2:54 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

There are ContactMechWorker.getCurrentPostalAddress

ContactMechWorker.getPartyPostalAddresses

1) To get party's data, either we should have all the code in a class should be exposed as a service, to avoid confusion. Right now, it's partially from the service (i.e. email & telephone) and partially Does this makes sense ?, if yes, then I thought of making a service ContactMechWorker.getPartyPostalAddresses, but then I noticed that the parameter for these methods is ServletRequest object. In this can be done is create a service and can it from the methods above, Please let me know your thoughts ? or am I missing something else ?

But yes no services, maybe because it's not needed ?

Jacques

From: "Abdullah Shaikh" <abdullah.sha...@viithiisys.com>

There are services to get the party telephone & email,
getPartyTelephone &

getPartyEmail respectively, but no service to get the party postal

address.


party's
postal address. What do you think ?

I can submit a patch for getPartyPostalAddress service, to get the

smime.p7s
Description: S/MIME cryptographic signature