Hi Hans, Firstly, even if re-sizing can be done using the new system...how do you suggest the issues of bulk upload can be tackled, without maintaining 2 separate directory structures for images?
Secondly, the JIRA issue may be open for 10 days...that does not mean, its necessarily approved of. I am no expert of the code...but i do not find if any of the other more experienced committers and contributors have made any comment of this functionality. i am not sure if any opinion was sought either. For eg. when the code was migrated to jQuery their was a conscious effort from the contributors to solicit feedback and opinion. Thirdly, the fact that i have been following the mailing list directly is what made me identify this issue and still believe their is no reason you should replace the existing structure...when your code could have been made optional for those who wanted to use it rather than being forced to use it. Please do not mis-construe that i am suggesting on the quality of code, all that i am saying is that it could have been made optional without removing the existing functionality. and as Eric mentioned "Rule #1 for a committer is the same as for a doctor: first do no harm. Nothing should be committed that breaks existing functionality without replacing it either before or in the same commit. Whatever you are working with someone developed it and chances are someone is using it, and possibly MANY people." thanks Rohit ----- saanjhi.com -- View this message in context: http://ofbiz.135035.n4.nabble.com/Re-svn-commit-r1076507-deletes-the-images-folder-tp3343463p3351328.html Sent from the OFBiz - User mailing list archive at Nabble.com.
