+1 This is a must and would help a lot in terms of ease of adoption for new users.
Regards, Pratiek > On 12-Oct-2017, at 3:01 AM, Jacques Le Roux <[email protected]> > wrote: > > Thanks Rajesh, Deepak, > > Please guys open a thread on dev ML to continue there > > Thanks > > Jacques > > > Le 11/10/2017 à 20:07, Deepak Dixit a écrit : >> I think we can make it configurable, we can get the tax calculation service >> dynamically and it can be configured based on store, like >> ProductStoreTaxSetting (or better name) this will contains tax calculation >> service name for specific store if its not configured system will use >> rateProductTaxCalc as default tax calculation. >> >> >> It will allow us to use different tax calculation service as per business >> need. >> >> Thanks & Regards >> -- >> Deepak Dixit >> www.hotwaxsystems.com >> www.hotwax.co >> >> On Wed, Oct 11, 2017 at 11:26 PM, Rajesh Mallah <[email protected]> >> wrote: >> >>> Hi Jacques , >>> >>> The patch is quite simple and we would readily contribute. >>> I am sure many Indian adopters would have already developed it >>> for their installations. >>> >>> But without generalising it , it is difficult to convert it to a patch >>> for OOTB feature set. >>> >>> At the same time GST is too important here(in India) and will possibly >>> stay. >>> >>> Any accounting system that does not handle GST here is *not* usable. >>> The recent GST rollout ( since 1st Apr 2017) has itself created a huge >>> (short-term) market of migrations and accounting software upgrades. >>> >>> I just hope this requirement gets its due attention and some way >>> is found to either cleanly extend Ofbiz accounting to handle such >>> taxation methods OR make it possible for adopters to have user-defined >>> handling for a class/category of TaxAuthorities. >>> >>> I feel if we are simply able to categorize TaxAuthorities in user >>> defined Categories the logic can be cleanly developed and applied. >>> Assuming that such a facility exists, the work flow for enduser to >>> implement GST would be. >>> >>> >>> (1) Create a new TaxAuthorityCategory --> say "India GST" >>> (2) Place the TaxAuthority in the new category "India GST" >>> (2) In calcTax >>> >>> if ( taxAuth.Category contains "India GST") // assuming >>> TaxAuthorityCategory is 1-to-many relation. >>> { >>> // apply Custom logic for GST >>> } >>> >>> ========================= >>> >>> essentially we(end-user) shall be in a position to apply any custom logic >>> to a given >>> category of taxAuthority. as Mr Deepak says , >>> >>> "GST is common but how to calculate GST is different" >>> >>> I concur here and feel that generalizing it may be too difficult a task and >>> will not even find >>> too many matching candidates. instead if the framework provides a >>> categorization >>> (or equivalent ) people can write their custom logic (however complicated) >>> based on >>> their local rules. >>> >>> >>> >>> regds >>> mallah. >>> >>> >>> >>> >>> On Wed, Oct 11, 2017 at 7:59 PM, Jacques Le Roux < >>> [email protected]> wrote: >>> >>>> Hi Rajesh, >>>> >>>> What you need does not exist. If it could be generalised and used all >>> over >>>> the world that would be perfect. >>>> >>>> This need to be discussed in dev ML in order for everybody to agree (or >>> at >>>> least get a consensus) and so avoid wasting time >>>> >>>> Then we can create a Jira and if possible attach a patch >>>> >>>> Thanks >>>> >>>> Jacques >>>> >>>> >>>> >>>> Le 11/10/2017 à 13:15, Rajesh Mallah a écrit : >>>> >>>>> Hello Deepak / Everyone , >>>>> >>>>> We have been able to achieve the selective application of taxes by >>>>> modifying the service calcTax ( java function: rateProductTaxCalc ) >>>>> it works as expected. >>>>> >>>>> The logic works by removing those taxes which are not applicable as per >>>>> the situation (ie based on Shipping addresses) >>>>> >>>>> However we would want the implement it in a more generic manner, >>>>> rite now the code checks specific PartyIDs associated with the >>>>> TaxAuthority, >>>>> is there any way to indicate that this specific handling of taxes should >>>>> be >>>>> limited to certain kind of taxauthorities ? >>>>> >>>>> Is there way of setting some meta-data on TaxAuthority or some kind of >>>>> classification. >>>>> >>>>> regds >>>>> mallah. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On Tue, Oct 10, 2017 at 12:34 AM, Deepak Dixit < >>>>> [email protected]> wrote: >>>>> >>>>> Sure , >>>>>> Please let us know if you face any issue. :) >>>>>> >>>>>> Thanks & Regards >>>>>> -- >>>>>> Deepak Dixit >>>>>> www.hotwaxsystems.com >>>>>> www.hotwax.co >>>>>> >>>>>> On Tue, Oct 10, 2017 at 12:21 AM, Rajesh Mallah < >>> [email protected] >>>>>> wrote: >>>>>> >>>>>> Thanks it helps. Shall give it a shot. >>>>>>> regds >>>>>>> mallah. >>>>>>> >>>>>>> On Tue, Oct 10, 2017 at 12:01 AM, Deepak Dixit < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>> Hi Rajesh, >>>>>>>> There are two way, >>>>>>>> >>>>>>>> 1. You can do changes in applications/accounting/src/ >>>>>>>> main/java/org/apache/ofbiz/accounting/tax/TaxAuthorityServices.java >>>>>>>> >>>>>>> and >>>>>>> create patch and maintain it in your custom component. >>>>>>>> 2. You can override service calTax and/or related services/method in >>>>>>>> >>>>>>> your >>>>>>> custom component. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks & Regards >>>>>>>> -- >>>>>>>> Deepak Dixit >>>>>>>> www.hotwaxsystems.com >>>>>>>> www.hotwax.co >>>>>>>> >>>>>>>> On Mon, Oct 9, 2017 at 11:56 PM, Rajesh Mallah < >>>>>>>> >>>>>>> [email protected]> >>>>>>> wrote: >>>>>>>> Thanks Deepak , Appreciate your response. >>>>>>>>> I had a glance over >>>>>>>>> >>>>>>>>> applications/accounting/servicedef/services_tax.xml & >>>>>>>>> applications/accounting/src/main/java/org/apache/ofbiz/ >>>>>>>>> >>>>>>>> accounting/tax/ >>>>>>> TaxAuthorityServices.java >>>>>>>>> looks encouraging! >>>>>>>>> >>>>>>>>> how should the change be managed to survive ofbiz upgrades? >>>>>>>>> >>>>>>>>> are we expected to change TaxAuthorityServices.java ? >>>>>>>>> >>>>>>>>> >>>>>>>>> regds >>>>>>>>> mallah. >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Oct 9, 2017 at 11:31 PM, Deepak Dixit < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>> Hi Rajesh, >>>>>>>>>> To calculate GST you need to write custom calc tax service, that >>>>>>>>>> >>>>>>>>> honor >>>>>>>> the >>>>>>>>>> shipFrom address as well. >>>>>>>>>> GST is common but how to calculate GST is different, As per Indian >>>>>>>>>> >>>>>>>>> context >>>>>>>>> >>>>>>>>>> GST is calculated based on shipFrom and ShipTo address. >>>>>>>>>> >>>>>>>>>> You need some changes in calcTax service and getTaxAuthorities >>>>>>>>>> >>>>>>>>> methods >>>>>>>> that >>>>>>>>>> return the taxAuthority.OFBiz has capability to setup different >>>>>>>>>> taxAuthParties. So with proper data setup along with some changes >>>>>>>>>> >>>>>>>>> you >>>>>>> can >>>>>>>>> setup GST tax calculation properly. >>>>>>>>>> >>>>>>>>>> Thanks & Regards >>>>>>>>>> -- >>>>>>>>>> Deepak Dixit >>>>>>>>>> www.hotwaxsystems.com >>>>>>>>>> www.hotwax.co >>>>>>>>>> >>>>>>>>>> On Mon, Oct 9, 2017 at 9:45 PM, Rajesh Mallah < >>>>>>>>>> >>>>>>>>> [email protected] >>>>>>>> wrote: >>>>>>>>>> We find that most of logic of Tax is in: >>>>>>>>>>> applications/accounting/src/main/java/org/apache/ofbiz/ >>>>>>>>>>> >>>>>>>>>> accounting/tax/ >>>>>>>>> TaxAuthorityServices.java >>>>>>>>>>> can/should we modify it as per our need or there is a >>>>>>>>>>> >>>>>>>>>> better/easier >>>>>>> way? >>>>>>>>>> As GST requirement is very common(universal) now in India , i am >>>>>>>>>> curious >>>>>>>>>> how people have implemented >>>>>>>>>>> here using OfBiz. >>>>>>>>>>> >>>>>>>>>>> regds >>>>>>>>>>> mallah. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Mon, Oct 9, 2017 at 8:13 PM, Rajesh Mallah < >>>>>>>>>>> >>>>>>>>>> [email protected] >>>>>>>>> wrote: >>>>>>>>>>> Hi , >>>>>>>>>>>> I need help regarding how to apply taxes broadly based on the >>>>>>>>>>>> fact whether the supplier and consumer are in same state or >>>>>>>>>>>> >>>>>>>>>>> not. >>>>>>> We are able to apply taxes based on GEO ID of the customer but >>>>>>>>>>>> what is really required is the below: >>>>>>>>>>>> >>>>>>>>>>>> If Supplier.state == Customer.state >>>>>>>>>>>> add adjustment SGST @ X% >>>>>>>>>>>> add adjustment CGST @ X% >>>>>>>>>>>> else >>>>>>>>>>>> add adjustment IGST @ X+X% >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> where: >>>>>>>>>>>> CGST --> Central Goods & Services Tax >>>>>>>>>>>> SGST --> State Goods & Services Tax >>>>>>>>>>>> IGST --> Integrated Goods & Services Tax >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Any help on this regard is solicited. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> regds >>>>>>>>>>>> mallah. >>>>>>>>>>>> >>>>>>>>>>>> >
