It's nice to see that you were on top of this already.
My only issue with your fix is that it can be ambiguous as to which comes
first (params or exception). I'd much prefer putting the exception at the
front of the method signature (as was suggested by another user in either
this or the Logback mailing list)
i.e. error(Throwable t, String msg, Object params...)
This makes it much more clear where the exception should be placed. And,
like what was said by the other user, you could also optionally put the
exception into the message as a parameter without casting.
Thanks,
Christopher White
Sr. Programmer
1-617-772-2403
[EMAIL PROTECTED]
Joern Huxhorn <[EMAIL PROTECTED]>
Sent by: [EMAIL PROTECTED]
04/24/2008 10:24 AM
Please respond to
User list for the slf4j project <[email protected]>
To
User list for the slf4j project <[email protected]>
cc
Subject
Re: [slf4j-user] Java 5 version of SLF4J?
[EMAIL PROTECTED] wrote:
> I did know that I can parameterize up to 2 parameters, which is nice.
But
> I also think that it is annoying to have to remember to change the
syntax
> once you hit 3+ parameters. Along with this, it is also annoying to have
> to remember to change syntax when logging errors (cannot use paramatized
> strings). It would be nice if things were more consistent.
>
> -Chris
I agree 100%.
Please take a look at http://bugzilla.slf4j.org/show_bug.cgi?id=70
Those are IMO the only two downsides of slf4j/logback...
Joern.
_______________________________________________
user mailing list
[email protected]
http://www.slf4j.org/mailman/listinfo/user
*************************** IMPORTANT
NOTE***************************** The opinions expressed in this
message and/or any attachments are those of the author and not
necessarily those of Brown Brothers Harriman & Co., its
subsidiaries and affiliates ("BBH"). There is no guarantee that
this message is either private or confidential, and it may have
been altered by unauthorized sources without your or our knowledge.
Nothing in the message is capable or intended to create any legally
binding obligations on either party and it is not intended to
provide legal advice. BBH accepts no responsibility for loss or
damage from its use, including damage from virus.
************************************************************************_______________________________________________
user mailing list
[email protected]
http://www.slf4j.org/mailman/listinfo/user
