On Thu, Sep 1, 2011 at 8:35 AM, Jukka Zitting <[email protected]> wrote:
> Hi,
>
> On Wed, Aug 31, 2011 at 2:15 PM, Michael McCandless
> <[email protected]> wrote:
>> I can appreciate this motivation, ie "convenience trumps consistency",
>> here.
>>
>> Still this inconsistency can lead to confusion and to bugs, but since
>> it's only one API that's "the exception" I think it's OK?
>>
>> But maybe we can beef up its javadocs a bit, saying "NOTE: unlike all
>> other APIs parsing from an InputStream, this API closes the incoming
>> InputStream for you for convenience" or something?
>
> I added something along these lines in revision 1164049.

Awesome, thanks Jukka!  It looks great, but just a small typo: taken
should be take in "Unlike most other Tika methods that taken an"

Mike McCandless

http://blog.mikemccandless.com

Reply via email to