i, personally, will not be patching or releasing anymore Tools 1.x stuff. but you are more than welcome to continue that branch, if you like.
On Fri, Sep 10, 2010 at 11:28 AM, Christopher Schultz <ch...@christopherschultz.net> wrote: > Nathan, > > On 9/7/2010 11:36 AM, Nathan Bubna wrote: >> according to both the code and javadocs, that's what it is supposed to >> do when you pass a relative url into that method. there isn't really >> a method in Tools 1.4's LinkTool that does what you want. all >> setAbsolute can do in 1.4 is: >> >> $link.absolute('/foo') -> http://host/context/foo >> $link.absolute('foo') -> http://host/context/foo >> $link.absolute('http://althost/foo') -> http://althost/foo > > That's what I'm experiencing, here. Sounds like a bug that should be > identified, but not fixed (due to backward-compatibility). If 1.4 is > still being supported, perhaps a "abosoluteWorks" method (or something > similar) could be added that actually works. > > I haven't read the code to determine why it's broken, though. > > Are we still accepting patches against 1.4? > > For now, I've just done this: > > ${request.scheme}://${request.serverName}:${request.serverPort}/path/to/my/resource > > It gets the job done, but isn't terribly elegant. > > -chris > > --------------------------------------------------------------------- To unsubscribe, e-mail: user-unsubscr...@velocity.apache.org For additional commands, e-mail: user-h...@velocity.apache.org