Regardless of offense taken due to his approach in describing them, some of Thomas' suggestions are reasonable (some switch statements are near replicas, many unit tests are framed as integration tests). Some are simply esthetic (de gustibus and so on) and some are (IMHO) not such a great thing at all.
Zookeeper is pretty open to positive change, but not very open to new-comers appearing with suggestions for extensive re-writes just to please a particular esthetic preference. And frankly, complaining in other fora decreases credibility with me even more than just complaining does. Establishing a record of viable improvements increases credibility. And, what do you know, we just re-invented Apache meritocracy from first principles. On Wed, Jun 15, 2011 at 9:19 PM, Fournier, Camille F. < [email protected]> wrote: > > Again, you seem too easily offended when touching on the subject, > > which makes Thomas' points valid. > > No it doesn't. He is allowed to be offended and it has no bearing on the > truth of the matter. This isn't a Shakespearian play.
