Hi Edwin,
Looks good in general, one comment though: 1. A nit - the COMPONENT_PROJECT_URLs vary between trailing slash/no trailing slash: COMPONENT_PROJECT_URL= http://ant.apache.org vs. COMPONENT_PROJECT_URL= http://httpd.apache.org/ In some cases this will end up with a double-slash in a URL for an archive: +COMPONENT_PROJECT_URL= http://ghostscript.com/ COMPONENT_SRC= $(COMPONENT_NAME)-$(COMPONENT_VERSION) COMPONENT_ARCHIVE= $(COMPONENT_SRC).tar.gz COMPONENT_ARCHIVE_HASH= sha1:96e75675efa0f00813f1608ba2c3833f4103ba19 -COMPONENT_ARCHIVE_URL=http://ghostscript.com/releases/$(COMPONENT_ARCHIVE) +COMPONENT_ARCHIVE_URL= $(COMPONENT_PROJECT_URL)/releases/$(COMPONENT_ARCHIVE) (Similar occurs in graphviz, unixtop, unixodbc and a couple of other packages).
You're being kind. There are a few more than that. :-) I do want consistency here, so I've removed the trailing slashes from all COMPONENT_PROJECT_URL lines in the component Makefiles. The list of affected files is included below. New webrev at: http://jurassic.us.oracle.com/~richb/7037821-v2/ I've also rerun my nightly build. Log files are under: /net/stard.us.oracle.com/tank/ws/UL/7037821/i386/nightly/logs.2011-11-22.08:49/ Thanks. ---- The following Makefiles have had their COMPONENT_PROJECT_URL lines changed: .../components/a2ps/Makefile .../components/apache2-modules/mod_dtrace/Makefile .../components/apache2-modules/mod_fcgid/Makefile .../components/apache2-modules/mod_jk/Makefile .../components/apache2-modules/mod_perl/Makefile .../components/apache2-modules/mod_proxy_html/Makefile .../components/apache2-modules/mod_security2/Makefile .../components/apache2/Makefile .../components/autoconf/Makefile .../components/autogen/Makefile .../components/automake/automake-1.10/Makefile .../components/automake/automake-1.9.6/Makefile .../components/bcc/Makefile .../components/binutils/Makefile .../components/bison/Makefile .../components/bzip2/Makefile .../components/convmv/Makefile .../components/coreutils/Makefile .../components/cvs/Makefile .../components/diffutils/Makefile .../components/ejabberd/Makefile .../components/elinks/Makefile .../components/emacs/Makefile .../components/erlang/Makefile .../components/flex/Makefile .../components/fping/Makefile .../components/gawk/Makefile .../components/gcc3/Makefile .../components/gettext/Makefile .../components/ggrep/Makefile .../components/ghostscript/Makefile .../components/git/Makefile .../components/gnu-gs-fonts-other/Makefile .../components/gnu-gs-fonts-std/Makefile .../components/gnump/Makefile .../components/graphviz/Makefile .../components/gtar/Makefile .../components/guile/Makefile .../components/gzip/Makefile .../components/hal-cups-utils/Makefile .../components/hplip/Makefile .../components/ircii/Makefile .../components/isc-dhcp/Makefile .../components/junit/Makefile .../components/less/Makefile .../components/libevent/Makefile .../components/libmng/Makefile .../components/libneon/Makefile .../components/libsigsegv/Makefile .../components/libtool/Makefile .../components/libusb/ugen/Makefile .../components/libusb/wrapper/Makefile .../components/lighttpd/Makefile .../components/logilab-astng/Makefile .../components/logilab-common/Makefile .../components/m4/Makefile .../components/make/Makefile .../components/mc/Makefile .../components/meld/Makefile .../components/mercurial/Makefile .../components/mpfr/Makefile .../components/ncftp/Makefile .../components/net-snmp/Makefile .../components/nethack/Makefile .../components/nmap/Makefile .../components/ntp/Makefile .../components/open-fabrics/Makefile .../components/openldap/Makefile .../components/p7zip/Makefile .../components/patch/Makefile .../components/perl_modules/pmtools/Makefile .../components/php-5_2/Makefile .../components/proftpd/Makefile .../components/pwgen/Makefile .../components/python/cherrypy/Makefile .../components/python/coverage/Makefile .../components/python/ldtp/Makefile .../components/python/mako/Makefile .../components/python/pybonjour/Makefile .../components/python/pycups/Makefile .../components/python/pycurl/Makefile .../components/python/python26/Makefile .../components/python/python27/Makefile .../components/quagga/Makefile .../components/sane-backends/Makefile .../components/sane-frontends/Makefile .../components/sed/Makefile .../components/slrn/Makefile .../components/spawn-fcgi/Makefile .../components/squid/Makefile .../components/stdcxx/Makefile .../components/subversion/Makefile .../components/swig/Makefile .../components/tcl/expect/Makefile .../components/tcl/tcl/Makefile .../components/tcl/tk/Makefile .../components/tcltls/Makefile .../components/texinfo/Makefile .../components/tidy/Makefile .../components/top/Makefile .../components/wget/Makefile .../components/which/Makefile .../components/wireshark/Makefile .../components/zsh/Makefile _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
