On 11/22/11 01:46 PM, Danek Duvall wrote:
Rich Burridge wrote:
Hi Edwin,
Looks good in general, one comment though:
1. A nit - the COMPONENT_PROJECT_URLs vary between trailing slash/no trailing
slash:
COMPONENT_PROJECT_URL= http://ant.apache.org
vs.
COMPONENT_PROJECT_URL= http://httpd.apache.org/
In some cases this will end up with a double-slash in a URL for an archive:
+COMPONENT_PROJECT_URL= http://ghostscript.com/
COMPONENT_SRC= $(COMPONENT_NAME)-$(COMPONENT_VERSION)
COMPONENT_ARCHIVE= $(COMPONENT_SRC).tar.gz
COMPONENT_ARCHIVE_HASH= sha1:96e75675efa0f00813f1608ba2c3833f4103ba19
-COMPONENT_ARCHIVE_URL=http://ghostscript.com/releases/$(COMPONENT_ARCHIVE)
+COMPONENT_ARCHIVE_URL= $(COMPONENT_PROJECT_URL)/releases/$(COMPONENT_ARCHIVE)
(Similar occurs in graphviz, unixtop, unixodbc and a couple of other packages).
You're being kind. There are a few more than that. :-)
I do want consistency here, so I've removed the trailing slashes from all
COMPONENT_PROJECT_URL lines in the component Makefiles. The list of
affected files is included below.
See, I like the trailing slash on the URL, because that's the actual URL's
address -- if you don't use it, then the server will kindly tell you to add
a slash and try again, so access is slower.
If you want the URLs in the packages to come out sparkling, then you
probably have to have things like
COMPONENT_ARCHIVE_URL =
$(COMPONENT_PROJECT_URL)releases/$(COMPONENT_ARCHIVE)
which at least looks weird only in the makefile.
I didn't see any smilies so I'm not completely sure you were attempting humor.
Yup, we each have our own preferences. I can certainly go back again
and change those 104 occurrences back the other way, and adjust another
line in each of those 104 Makefiles, and then rebuild everything to make
sure I haven't broken anything, but then Norm (or whoever is my RTI
advocate) might come along and tell me they prefer it the other way.
What's the best way to resolve this?
OCDanek
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
