Hey Danek,
On 12/12/11 01:10 PM, Danek Duvall wrote:
Kevin Crowe wrote:
Looking for a code review of a couple libxml2 fixes:
http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-libxml2/webrev/
How do you want these reviewed? Do you want the actual code changes as
delivered by the patches reviewed against the security bugs they're
intended to solve, or just as a set of three black-box patches that are
applied to the source as part of the prep target? Did you get these
Good question. I guess if I had a preference it would be to have them
reviewed as a set of three black-box patches applied to the source
during prep since I made the patches from the upstream repo (they were
not my invention - see below.)
Even though they are not my creation I'm open to folks looking into the
changes further as there's always room for other problems to creep in
(bad code upstream, a patch that requires other upstream changes to work
right that I didn't take, my own errors, etc)
patches from somewhere else and add them changing only the header if
necessary, or did you write the patches yourself?
While the patches are (or should be) exactly as they are in the upstream
repo I made the changes by hand[1] so that I could fix tabbing/spacing
the way I wanted and then diff'd them against the upstream changes to
ensure accuracy.
I've updated the patches slightly to include a note at the beginning of
the patch to help explain where the changes are from.
Latest:
http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-libxml2/webrev/
Diffs from original:
http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-libxml2/webrev.fixes-1/
Original:
http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-libxml2/webrev.orig/
Thanks,
Kevin.
[1] by hand I mean: cp file.c new.file.c; vi new.file.c to make
changes; diff -u file.c new.file.c > file.patch
had the changes been any larger I'd probably have done something less
edit intensive/error prone, old cstyle habits die hard.
Danek
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
