Kevin Crowe wrote: > Hey Danek, > > On 12/12/11 01:10 PM, Danek Duvall wrote: > >Kevin Crowe wrote: > > > >>Looking for a code review of a couple libxml2 fixes: > >>http://jurassic.us.oracle.com/net/jade2/builds1/kc28005/userland-u1-libxml2/webrev/ > >How do you want these reviewed? Do you want the actual code changes as > >delivered by the patches reviewed against the security bugs they're > >intended to solve, or just as a set of three black-box patches that are > >applied to the source as part of the prep target? Did you get these > > Good question. I guess if I had a preference it would be to have > them reviewed as a set of three black-box patches applied to the > source during prep since I made the patches from the upstream repo > (they were not my invention - see below.)
Then from that point of view, LGTM. > While the patches are (or should be) exactly as they are in the upstream > repo I made the changes by hand[1] so that I could fix tabbing/spacing > the way I wanted and then diff'd them against the upstream changes to > ensure accuracy. I'd advise against doing that. This isn't our code, and we don't even maintain the code itself in the source repo, so our (or your) standards have nothing to do with it, and re-indenting the patches for style points is a drain on resources without any real-world gain. Apply your cstyle habits to code you're actually writing. Thanks, Danek _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
