Hey Rich,

These changes look fine to me.

Out of curiosity just two quick questions about the upgrade - they don't deliver any tests with the new version?  And is the PKG_PROTO_DIRS in the Makefile still necessary to pick up the man pages?  For that matter, is the COMPONENT_PRE_CONFIGURE_ACTION still necessary?  I wonder if a comment as to why it's necessary would be useful to maintainers going forward?

Thanks,
Kevin.


On 01/11/12 08:45 AM, Rich Burridge wrote:

Hi,

Could I please get a code review for my changes for:

  7122666 libnet should be updated to version 1.1.5
  http://monaco.us.oracle.com/detail.jsf?cr=7122666

  6776222 libnet is not IPv6 capable
  http://monaco.us.oracle.com/detail.jsf?cr=6776222

Webrev is at:

  http://jurassic.us.oracle.com/~richb/7122666-6776222-v1/

x86 workspace (with libnet built) is at:

  /net/stard.us.oracle.com/tank/ws/UL/7122666-6776222/

See the Bugster CR's for more details.

Thanks.

_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss


--



Kevin Crowe | Software Engineer | +1.781.442.1378
Oracle Solaris Core TechnologyUserland Gate
1 Network Drive

Burlington, MA 01803
Mailstop: UBUR02-201
Email: [email protected]

_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to