Hey Rich,
Thanks for the additional info! I was more curious than disbelieving of
anything but the details are appreciated. I guess it comes from
suspicion/hope that in upgrades maybe some of the hokey things we had to
do in older versions might not be necessary anymore...
The comment for the preconfigure action I was only suggesting based on
what some folks did when porting stuff from SFW to Userland - just a
comment about why it's necessary or what doesn't work without it. Hell,
maybe I was the only one that put comments in for that? (see autogen,
doxygen, etc) If I recall though I only did it because it was suggested
to me by a reviewer. Certainly not necessary esp as it's outside of
what you are changing, not a big deal.
Thanks,
Kevin.
On 01/11/12 11:22 AM, Rich Burridge wrote:
On 01/11/12 07:50 AM, Kevin Crowe wrote:
These changes look fine to me.
Okay.
Out of curiosity just two quick questions about the upgrade - they
don't deliver any tests with the new version?
Correct. The old version didn't have any built in tests either.
But libnet is used by the GLDv3 test suite. The Crossbow test
team in China have confirmed that the portion of that test suite
that uses libnet, still correctly works with the new version of the
library. See the Bugster CR for more details.
And is the PKG_PROTO_DIRS in the Makefile still necessary to pick up
the man pages?
Yes. Without it the build fails with:
...
Couldn't find 'usr/share/man/man3/libnet-functions.h.3' in any of the
specified search directories:
/tank/ws/UL/libnet-upgrade/components/libnet
/tank/ws/UL/libnet-upgrade/components/libnet/build
/tank/ws/UL/libnet-upgrade/components/libnet/build/prototype/i386
/tank/ws/UL/libnet-upgrade/components/libnet/build/prototype/i386/mangled
/tank/ws/UL/libnet-upgrade/components/libnet/libnet-1.1.5
Couldn't find 'usr/share/man/man3/libnet-macros.h.3' in any of the
specified search directories:
/tank/ws/UL/libnet-upgrade/components/libnet
/tank/ws/UL/libnet-upgrade/components/libnet/build
/tank/ws/UL/libnet-upgrade/components/libnet/build/prototype/i386
/tank/ws/UL/libnet-upgrade/components/libnet/build/prototype/i386/mangled
/tank/ws/UL/libnet-upgrade/components/libnet/libnet-1.1.5
Couldn't find 'usr/share/man/man3/libnet.h.3' in any of the specified
search directories:
/tank/ws/UL/libnet-upgrade/components/libnet
/tank/ws/UL/libnet-upgrade/components/libnet/build
/tank/ws/UL/libnet-upgrade/components/libnet/build/prototype/i386
/tank/ws/UL/libnet-upgrade/components/libnet/build/prototype/i386/mangled
/tank/ws/UL/libnet-upgrade/components/libnet/libnet-1.1.5
gmake: ***
[/tank/ws/UL/libnet-upgrade/components/libnet/build/manifest-i386-libnet.depend]
Error 1
...
For that matter, is the COMPONENT_PRE_CONFIGURE_ACTION still necessary?
Yes. Without it the build fails with:
...
(cd /tank/ws/UL/libnet-upgrade/components/libnet/build/i86 ;
/usr/bin/env CONFIG_SHELL="/bin/bash" /bin/bash \
/tank/ws/UL/libnet-upgrade/components/libnet/libnet-1.1.5/configure
CC="/usr/sfw/bin/gcc" CXX="/usr/sfw/bin/g++" --prefix=/usr
--mandir=/usr/share/man --bindir=/usr/bin --libdir=/usr/lib
--sbindir=/usr/sbin
--srcdir=/tank/ws/UL/libnet-upgrade/components/libnet/build/i86
CFLAGS="-m32 -O3 -g -fPIC")
configure: error: cannot find sources (src/libnet_build_ip.c) in
/tank/ws/UL/libnet-upgrade/components/libnet/build/i86
gmake: ***
[/tank/ws/UL/libnet-upgrade/components/libnet/build/i86/.configured]
Error 1
I wonder if a comment as to why it's necessary would be useful to
maintainers going forward?
What sort of comment would you like to see here? I ask because there are
a *lot* of Userland components that do something similar to this, and
those
don't seem to have any comments. And I also haven't changed anything
here.
Thanks for the review.
On 01/11/12 08:45 AM, Rich Burridge wrote:
Hi,
Could I please get a code review for my changes for:
7122666 libnet should be updated to version 1.1.5
http://monaco.us.oracle.com/detail.jsf?cr=7122666
6776222 libnet is not IPv6 capable
http://monaco.us.oracle.com/detail.jsf?cr=6776222
Webrev is at:
http://jurassic.us.oracle.com/~richb/7122666-6776222-v1/
x86 workspace (with libnet built) is at:
/net/stard.us.oracle.com/tank/ws/UL/7122666-6776222/
See the Bugster CR's for more details.
Thanks.
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
--
<http://www.oracle.com/>
Kevin Crowe| Software Engineer | +1.781.442.1378
OracleSolaris Core Technology– Userland Gate
1 Network Drive
Burlington, MA 01803
Mailstop: UBUR02-201
Email: [email protected] <mailto:[email protected]>
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
