Hi Rich,

components/ggrep/Makefile:
  33 # as xz is not currently part of the Solaris 11 Update 11 CBE. We
                                                                                
           ^
                                                                               
Update 1

The rest looks fine to me.

Thanks,
April


On 01/18/12 12:39 PM, Rich Burridge wrote:
On 01/17/12 11:28 AM, Rich Burridge wrote:
Your changes look good to me.

Okay (but I suspect there's going to be a -v2 coming tomorrow :-) ).

And here it is:

  http://jurassic.us.oracle.com/~richb/7121690-v2/

The only difference from the previous webrev is that it  tweaks the
definitions in the Makefile. See the related comment. I left the
.xz clause in the .../tools/userland-unpack script as it's going to
be needed at some point even if we can't use it now.

Thanks.




I assume the new requirement for Userland build systems will be Solaris 11 Update 1 build 8
instead of Solaris 11 FCS, to get the xz package.

Unfortunately not (at the time). See my previous message.

Thanks for the review.


On 01/17/12 08:52 AM, Rich Burridge wrote:
On 01/17/12 07:21 AM, Petr Sumbera wrote:
Hi Rich,

is it ok to use xz? I don't see it installed on sfw public build machines yet.

Not yet. As mentioned below , "Note that this will be dependent upon the integration of the XZ utility that's going through the RTI process at the moment (see CR #6884939)"


Thanks,

Petr

On 01/17/12 15:49, Rich Burridge wrote:
Hi all,

Could I please get a code review for the changes for:

7121690 Upgrade gnu grep to 2.10
http://monaco.us.oracle.com/detail.jsf?cr=7121690

Webrev is at:

http://jurassic.us.oracle.com/~richb/7121690-v1/

x86 ON workspace is at:

/net/stard.us.oracle.com/tank/ws/UL/7121690/

Build log is:

/net/stard.us.oracle.com/tank/ws/UL/7121690/components/ggrep/publish-trans.txt


See the Bugster CR for more details.

Note that this will be dependent upon the integration of the XZ utility that's going through the RTI process at the moment (see CR #6884939).

Thanks.

_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to