I am looking for a code review for:
7098984 gpg2 has fatal relocation error on libreadline.so.5 Basically, if you try and run "gpg2 --gen-key" it fails with this error: /usr/lib/libreadline.so.5: symbol tgetent: referenced symbol not found This is actually a bug in the readline module. The attached straightforward patch fixes this problem. This bug makes it a pain to generate a GPG key on Solaris since most users would likely not figure out the workaround of running with LD_PRELOAD_32 or LD_PRELOAD_64 set. This is my first attempt at fixing something in Userland or with Mercurial, so please let me know what the next steps should be. I am assuming I should just go ahead and fill out a WebRTI once this email request gets approval. Is that correct? Brian
diff -r 759bda8e4900 components/readline/Makefile --- a/components/readline/Makefile Tue Jan 10 15:50:30 2012 -0800 +++ b/components/readline/Makefile Tue Jan 17 22:08:09 2012 -0600 @@ -42,7 +42,7 @@ # readline likes to use ld directly and this is the easiest # way to get it to add -lc -LDFLAGS += -lc +LDFLAGS += -lc -ltermcap CONFIGURE_OPTIONS += --infodir=$(CONFIGURE_INFODIR) CONFIGURE_OPTIONS += --enable-shared CONFIGURE_OPTIONS += --disable-static
_______________________________________________ userland-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/userland-discuss
