Brian Cameron wrote:

I am looking for a code review for:

    7098984 gpg2 has fatal relocation error on libreadline.so.5

Basically, if you try and run "gpg2 --gen-key" it fails with this error:

/usr/lib/libreadline.so.5: symbol tgetent: referenced symbol not found

This is actually a bug in the readline module.  The attached
straightforward patch fixes this problem.  This bug makes it a pain to
generate a GPG key on Solaris since most users would likely not figure
out the workaround of running with LD_PRELOAD_32 or LD_PRELOAD_64 set.

This is my first attempt at fixing something in Userland or with
Mercurial, so please let me know what the next steps should be.  I am
assuming I should just go ahead and fill out a WebRTI once this email
request gets approval.  Is that correct?

The libreadline fix as proposed here is suspicious.

The tgetent symbol is defined in several different libraries present in Solaris:

libtermcap
libcurses
libncurses

By forcing libreadline to link with libtermcap, you are preventing other applications or libraries which may want to use libreadline to link with either libcurses or libncurses, because of the conflict created by libtermcap.

--Stefan

--
Stefan Teleman
Oracle USA Corporation
[email protected]

_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss

Reply via email to