components/libedit/Makefile:
26 COMPONENT_VERSION= 20110802-3.0
27 IPS_COMPONENT_VERSION= 3.0
...
29 COMPONENT_SRC= $(COMPONENT_NAME)-$(COMPONENT_VERSION)
COMPONENT_VERSION is used for the name of the archive file to be downloaded.
And IPS_COMPONENT_VERSION is for the package version # for the libedit
package.
Since you seem to have an update 20110802 to version 3.0, you
should include 20110802 in the IPS_COMPONENT_VERSION, to update and
distinguish
between this version 3.0 of libedit and a possible subsequent update of
version 3.0.
I don't know how libedit's versioning scheme works, but if there won't
be any
micro versions of 3.0 (e.g., 3.0.1), you might use 3.0.20110802 for
IPS_COMPONENT_VERSION.
In case there could be microversions, it would be better to use
3.0.0.20110802.
components/libedit/libedit.license:
This file should include the component name & version and TPNO #, per
the third party
license tool (it looks like TPNO #7013).
You can follow what was done for other components' license files.
See isc-dhcp/isc-dhcp.license or other license files for examples.
You have copyright lines included above the license, which is what
should be done for the BSD license,
although the third party tool entry doesn't list the copyright line,
only the license
(maybe the entry needs to be corrected?).
April
On 01/26/12 11:34 AM, Srinivasa Sarva wrote:
Any takers?
On 01/25/12 12:29, Srinivasa Sarva wrote:
Hi all,
Please review the code for
CR 7133007 Integrate Libedit into Userland
Webrev
http://jurassic.us.oracle.com/net/ssarva-us/export/home/srini/test/Jan24/webrev/index.html
Thanks
Srini
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
