Hi, > Could I please get a code review for the changes for: > > 7079363 gcc-3.p5m package manifest file shouldn't deliver .la files > http://monaco.us.oracle.com/detail.jsf?cr=7079363
Is that some requirement to not ship the *.la files? If the package wants them installed and it does not cause us any trouble it just additional work to be done on every component update. As a compromise I can see adding some sort of "devel" facet to the *.la files, since regular Solaris user will never make any use of those. Actually I'm not strictly against removing the files, I just wonder what are the reasons to be "smarter" than the package (gcc) itself? > Webrev is at: > > http://jurassic.us.oracle.com/~richb/7079363-v1/ Also if we just remove the files from *.p5m, future generations will not know that they have been removed on purpose. What about leaving the lines in the *.p5m file, just commented out? Or move them to the end of the *.p5m and comment them out there? Cheers -- Vlad _______________________________________________ userland-discuss mailing list userland-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/userland-discuss
