Thanks, Craig!
April
On 2/9/2012 3:30 PM, Craig Mohrman wrote:
No further comments based on this and your private email.
craig
----- april.c...@oracle.com wrote:
Hi Craig,
Thanks for the review!
Here's the webrev of diffs from the last webrev:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/s11-u1-ruby/webrev-2-diffs/
And here's a full webrev:
http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/s11-u1-ruby/webrev-2/
On 2/9/2012 3:00 PM, Craig Mohrman wrote:
components/ruby/Makefile
23 # Copyright (c) 2011, Oracle and/or its affiliates. All
rights reserved.
Add a 2012 copyright.
components/ruby/ruby-18.p5m
Add a 2012 copyright.
Thanks, fixed these.
I can't get into the secure bug viewer so no idea
was it says.
I sent you some information about the bug in a separate email.
Thanks,
April
Other than that these are my only comments.
----- april.c...@oracle.com wrote:
Could I please get a code review to fix:
7127211 problem with ruby
http://monaco.us.oracle.com/detail.jsf?cr=7127211
The webrev is here:
http://http://jurassic.us.oracle.com/net/sfwcfi/builds/apchin/s11-u1-ruby/webrev-1/
The patches have been changed:
02-mkconfig.rb.patch has been removed, because it is no longer
needed.
08-ruby-dtrace-1.8.7.patch has been regenerated because of ruby
source code changes.
02-code_objects-html_generator.patch is a new patch to deal with
building
the doc files in a consistent order for every build. See CR
7127211
for
more details.
Thanks,
April
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
_______________________________________________
userland-discuss mailing list
userland-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/userland-discuss
